You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/17 21:49:28 UTC
[GitHub] [openwhisk-deploy-kube] buggtb opened a new pull request #593:
Fixes SSL support for AWS ELBs and signed certificates
buggtb opened a new pull request #593: Fixes SSL support for AWS ELBs and signed certificates
URL: https://github.com/apache/openwhisk-deploy-kube/pull/593
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-deploy-kube] dgrove-oss closed pull request #593: Fixes
SSL support for AWS ELBs and signed certificates
Posted by GitBox <gi...@apache.org>.
dgrove-oss closed pull request #593: Fixes SSL support for AWS ELBs and signed certificates
URL: https://github.com/apache/openwhisk-deploy-kube/pull/593
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on issue #593: Fixes
SSL support for AWS ELBs and signed certificates
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #593: Fixes SSL support for AWS ELBs and signed certificates
URL: https://github.com/apache/openwhisk-deploy-kube/pull/593#issuecomment-607927662
Replaced by #597
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on issue #593: Fixes
SSL support for AWS ELBs and signed certificates
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #593: Fixes SSL support for AWS ELBs and signed certificates
URL: https://github.com/apache/openwhisk-deploy-kube/pull/593#issuecomment-600784437
At first read through, this looks reasonable. Thanks!
I will give it a whirl on IBM IKS service within the next 24 hours as a sanity check.
Could you fix the scancode violations:
```
[/home/travis/build/apache/openwhisk-deploy-kube/tools/travis/../../docs/k8s-aws.md]:
94: line has trailing whitespace.
108: line has trailing whitespace.
109: line has trailing whitespace.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on issue #593: Fixes
SSL support for AWS ELBs and signed certificates
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on issue #593: Fixes SSL support for AWS ELBs and signed certificates
URL: https://github.com/apache/openwhisk-deploy-kube/pull/593#issuecomment-603411629
@buggtb -- I tested your branch on an IKS cluster (IBM Kubernetes Service) and locally and everything worked fine. As expected non-AWS targets are not impacted.
If you could fix up the three lines in docs/k8s-aws.md that have trailing white space, I will merge the PR (I seem to not have permission to just fix them myself on your branch).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services