You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2014/09/25 20:53:22 UTC
git commit: Use a JmsQueue as a fallback when no type annotations are
present and we can't deduce from consumer. This provides a JMS complaint
result which doesn't impact how the Broker is really managing that
destination.
Repository: qpid-jms
Updated Branches:
refs/heads/master ef2e0d597 -> 38299e760
Use a JmsQueue as a fallback when no type annotations are present and we
can't deduce from consumer. This provides a JMS complaint result which
doesn't impact how the Broker is really managing that destination.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/38299e76
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/38299e76
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/38299e76
Branch: refs/heads/master
Commit: 38299e760f5f6abf061d630e9a265981846f9d49
Parents: ef2e0d5
Author: Timothy Bish <ta...@gmail.com>
Authored: Thu Sep 25 14:53:16 2014 -0400
Committer: Timothy Bish <ta...@gmail.com>
Committed: Thu Sep 25 14:53:16 2014 -0400
----------------------------------------------------------------------
.../jms/provider/amqp/message/AmqpDestinationHelper.java | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/38299e76/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java
index d84399d..202f5ce 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/message/AmqpDestinationHelper.java
@@ -46,7 +46,6 @@ public class AmqpDestinationHelper {
public static final String TEMP_TOPIC_ATTRIBUTES_STRING = TOPIC_ATTRIBUTE + "," + TEMPORARY_ATTRIBUTE;
// TODO - The Type Annotation seems like it could just be a byte value
- // TODO - How do we deal with the case where no type is present?
/*
* One possible way to encode destination types that isn't a string.
@@ -131,11 +130,8 @@ public class AmqpDestinationHelper {
}
}
- // fall back to a straight Destination
- // TODO - We don't have a non-abstract destination to create right now
- // and JMS doesn't really define a true non Topic / Queue destination
- // so how this would be handled elsewhere seems a mystery.
- return null;
+ // fall back to a Queue Destination since we need a real JMS destination
+ return new JmsQueue(address);
}
public void setToAddressFromDestination(AmqpJmsMessageFacade message, JmsDestination destination) {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org