You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/22 06:49:30 UTC

[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1947: ActiveMQ Default XPath evaluator could not be loaded

jamesnetherton opened a new pull request #1947:
URL: https://github.com/apache/camel-quarkus/pull/1947


   Fixes #1933


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1947: ActiveMQ Default XPath evaluator could not be loaded

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1947:
URL: https://github.com/apache/camel-quarkus/pull/1947#issuecomment-714420868


   Merging - test failure is unrelated.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1947: ActiveMQ Default XPath evaluator could not be loaded

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1947:
URL: https://github.com/apache/camel-quarkus/pull/1947#discussion_r509931514



##########
File path: extensions/activemq/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,2 @@
+ActiveMQ https://activemq.apache.org/selectors.html[XPath selectors] are not supported in native mode as the libraries to support it are not on the classpath
+by default.

Review comment:
       Well, it would require adding `activemq-broker` to the classpath. Which is not something we want to support, and wont work natively by default (which is why we exclude it from the dep tree).
   
   I can add a comment to that affect.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1947: ActiveMQ Default XPath evaluator could not be loaded

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1947:
URL: https://github.com/apache/camel-quarkus/pull/1947#discussion_r509928887



##########
File path: extensions/activemq/runtime/src/main/doc/limitations.adoc
##########
@@ -0,0 +1,2 @@
+ActiveMQ https://activemq.apache.org/selectors.html[XPath selectors] are not supported in native mode as the libraries to support it are not on the classpath
+by default.

Review comment:
       Hm... this sounds like they could be made to work if one adds the necessary libs. But it is obviously not true due to the substitution. Wouldn't something like "We have explicitly disabled ActiveMQ https://activemq.apache.org/selectors.html[XPath selectors] in the native mode because they would not work anyway, because of [the reason]" be more honest from us?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1947: ActiveMQ Default XPath evaluator could not be loaded

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1947:
URL: https://github.com/apache/camel-quarkus/pull/1947#issuecomment-714306061


   Latest commit improves the limitations explanation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel-quarkus] jamesnetherton merged pull request #1947: ActiveMQ Default XPath evaluator could not be loaded

Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1947:
URL: https://github.com/apache/camel-quarkus/pull/1947


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org