[GitHub] [superset] rusackas commented on a diff in pull request #19703: chore(build): upgrade less-loader

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #19703:
URL: https://github.com/apache/superset/pull/19703#discussion_r850166330


##########
superset-frontend/tools/eslint-plugin-theme-colors/package.json:
##########
@@ -9,9 +9,5 @@
   "keywords": [],
   "license": "Apache-2.0",
   "author": "Apache",
-  "dependencies": {},
-  "engines": {
-    "node": "^16.9.1",
-    "npm": "^7.5.4"

Review Comment:
   This was just bumped to support npm 8 in [this](https://github.com/apache/superset/pull/19365) PR. Not sure if it's _necessary_ but thought I should ping @villebro in case it is. 
   
   Happy to approve this otherwise, though if this doesn't become an objection. Thanks for tending to this!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org