You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Evgueni Brevnov (JIRA)" <ji...@apache.org> on 2006/10/26 15:01:16 UTC

[jira] Created: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9

[drlvm][testing] gc.Free fails for me on SUSE9
----------------------------------------------

                 Key: HARMONY-1978
                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
             Project: Harmony
          Issue Type: Bug
          Components: DRLVM
         Environment: ia32 SUSE9
            Reporter: Evgueni Brevnov
         Attachments: gc.Free.patch

gc.Free started to fail with the following log:

FAILED, Amount of free memory increases
FAILED, Amount of free memory increases
PASSED

With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
The behavior depends on initial memory reserved by GC for java heap.

The fix is in attach. Please review.

Thanks
Evgueni

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9

Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-1978?page=comments#action_12445073 ] 
            
Evgueni Brevnov commented on HARMONY-1978:
------------------------------------------

I'm OK with the Salikh's patch assumig it is acceptable to have somke tests which depends on configuration/implementation. In particular, initial heap size (-Xms) and GC implementation may affect test runs. What worries me a little is that test will fail in case of increase of free memory space. Salikh you said: "..(there is nothing wrong with free space increasing in the face of heap resize). "

Thanks
Evgueni

> [drlvm][testing] gc.Free fails for me on SUSE9
> ----------------------------------------------
>
>                 Key: HARMONY-1978
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: ia32 SUSE9
>            Reporter: Evgueni Brevnov
>         Attachments: gc.Free.1.patch, gc.Free.patch
>
>
> gc.Free started to fail with the following log:
> FAILED, Amount of free memory increases
> FAILED, Amount of free memory increases
> PASSED
> With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
> The behavior depends on initial memory reserved by GC for java heap.
> The fix is in attach. Please review.
> Thanks
> Evgueni

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9

Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1978?page=all ]

Salikh Zakirov updated HARMONY-1978:
------------------------------------

    Attachment: gc.Free.1.patch

-1 to gc.Free.patch. Reasons:
(1) gc.Free.patch does not address any of the problems desribed above,
i.e. warning will still be printed together with PASSED message, and the warning message
is incorrect (there is nothing wrong with free space increasing in the face of heap resize).
(2) it makes test almost useless. Initially, test checked sanity of the value returned by Runtime.freeMemory(),
after the modification it checks only trivial object allocation.

I suggest another patch to fix the issue: gc.Free.1.patch.
It contains 2 modifications to address issues:
1) in case of FAILED message terminate the test
2) do not attempt to allocate more than 1/2 of the space reported as free. Limit is set to free/4 as the allocation
is perfomed as geometry progression: 1+2+4+...
It still has an implementation assumption that GC will not resize the heap as long as less than 1/2 of the
heap is free, which I consider reasonable (and passing on both DRLVM and RI)

> [drlvm][testing] gc.Free fails for me on SUSE9
> ----------------------------------------------
>
>                 Key: HARMONY-1978
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: ia32 SUSE9
>            Reporter: Evgueni Brevnov
>         Attachments: gc.Free.1.patch, gc.Free.patch
>
>
> gc.Free started to fail with the following log:
> FAILED, Amount of free memory increases
> FAILED, Amount of free memory increases
> PASSED
> With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
> The behavior depends on initial memory reserved by GC for java heap.
> The fix is in attach. Please review.
> Thanks
> Evgueni

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9

Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1978?page=all ]

Geir Magnusson Jr updated HARMONY-1978:
---------------------------------------

    Patch Info: [Patch Available]

> [drlvm][testing] gc.Free fails for me on SUSE9
> ----------------------------------------------
>
>                 Key: HARMONY-1978
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: ia32 SUSE9
>            Reporter: Evgueni Brevnov
>         Attachments: gc.Free.1.patch, gc.Free.patch
>
>
> gc.Free started to fail with the following log:
> FAILED, Amount of free memory increases
> FAILED, Amount of free memory increases
> PASSED
> With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
> The behavior depends on initial memory reserved by GC for java heap.
> The fix is in attach. Please review.
> Thanks
> Evgueni

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9

Posted by "Salikh Zakirov (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-1978?page=comments#action_12444901 ] 
            
Salikh Zakirov commented on HARMONY-1978:
-----------------------------------------

above should read: "... GC will not resize the heap as long as at least half of the heap is free, ..."

> [drlvm][testing] gc.Free fails for me on SUSE9
> ----------------------------------------------
>
>                 Key: HARMONY-1978
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: ia32 SUSE9
>            Reporter: Evgueni Brevnov
>         Attachments: gc.Free.1.patch, gc.Free.patch
>
>
> gc.Free started to fail with the following log:
> FAILED, Amount of free memory increases
> FAILED, Amount of free memory increases
> PASSED
> With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
> The behavior depends on initial memory reserved by GC for java heap.
> The fix is in attach. Please review.
> Thanks
> Evgueni

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1978?page=all ]

Gregory Shimansky resolved HARMONY-1978.
----------------------------------------

    Resolution: Fixed

Patch has been applied.

> [drlvm][testing] gc.Free fails for me on SUSE9
> ----------------------------------------------
>
>                 Key: HARMONY-1978
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: ia32 SUSE9
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: gc.Free.1.patch, gc.Free.patch
>
>
> gc.Free started to fail with the following log:
> FAILED, Amount of free memory increases
> FAILED, Amount of free memory increases
> PASSED
> With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
> The behavior depends on initial memory reserved by GC for java heap.
> The fix is in attach. Please review.
> Thanks
> Evgueni

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1978?page=all ]

Gregory Shimansky reassigned HARMONY-1978:
------------------------------------------

    Assignee: Gregory Shimansky

> [drlvm][testing] gc.Free fails for me on SUSE9
> ----------------------------------------------
>
>                 Key: HARMONY-1978
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: ia32 SUSE9
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: gc.Free.1.patch, gc.Free.patch
>
>
> gc.Free started to fail with the following log:
> FAILED, Amount of free memory increases
> FAILED, Amount of free memory increases
> PASSED
> With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
> The behavior depends on initial memory reserved by GC for java heap.
> The fix is in attach. Please review.
> Thanks
> Evgueni

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-1978?page=comments#action_12448620 ] 
            
Gregory Shimansky commented on HARMONY-1978:
--------------------------------------------

This test gc.Free doesn't fail for me on SUSE9 and on other linuxes not to mention windows. What is it I am missing?

> [drlvm][testing] gc.Free fails for me on SUSE9
> ----------------------------------------------
>
>                 Key: HARMONY-1978
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: ia32 SUSE9
>            Reporter: Evgueni Brevnov
>         Assigned To: Gregory Shimansky
>         Attachments: gc.Free.1.patch, gc.Free.patch
>
>
> gc.Free started to fail with the following log:
> FAILED, Amount of free memory increases
> FAILED, Amount of free memory increases
> PASSED
> With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
> The behavior depends on initial memory reserved by GC for java heap.
> The fix is in attach. Please review.
> Thanks
> Evgueni

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9

Posted by "Evgueni Brevnov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-1978?page=all ]

Evgueni Brevnov updated HARMONY-1978:
-------------------------------------

    Attachment: gc.Free.patch

> [drlvm][testing] gc.Free fails for me on SUSE9
> ----------------------------------------------
>
>                 Key: HARMONY-1978
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: ia32 SUSE9
>            Reporter: Evgueni Brevnov
>         Attachments: gc.Free.patch
>
>
> gc.Free started to fail with the following log:
> FAILED, Amount of free memory increases
> FAILED, Amount of free memory increases
> PASSED
> With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
> The behavior depends on initial memory reserved by GC for java heap.
> The fix is in attach. Please review.
> Thanks
> Evgueni

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira