You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/12/22 17:05:58 UTC
[GitHub] [flink] meijies opened a new pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
meijies opened a new pull request #14468:
URL: https://github.com/apache/flink/pull/14468
## What is the purpose of the change
This pull request make the jdbc dynamic table flush the data in buffer to table when checkpoint.
## Brief change log
- Wrap the ```JdbcBatchingOutputFormat``` to ```GenericJdbcSinkFunction```, make flush method can be called when snapshot.
## Verifying this change
This change added tests and can be verified as follows:
- Added a unit tests for the data in buffer is flushed to database when snapshot.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no )
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14468:
URL: https://github.com/apache/flink/pull/14468
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "750035011",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* d2b4d901d51c87824302397aa6059fc255ce57f9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ee08bbbe2d3830f129c85472780136a72ece8f3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] meijies commented on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
meijies commented on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-750035011
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "750035011",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* d2b4d901d51c87824302397aa6059fc255ce57f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] meijies commented on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
meijies commented on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-750297131
@wuchong Can you help to review this pr at your convenience
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] meijies commented on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
meijies commented on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-750843218
Ok, I get it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ee08bbbe2d3830f129c85472780136a72ece8f3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] meijies commented on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
meijies commented on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749973352
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "750035011",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2b4d901d51c87824302397aa6059fc255ce57f9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223)
* 8b758a6aa9c3f9e5f7a053096816f186f7d39ee0 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* d2b4d901d51c87824302397aa6059fc255ce57f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "750035011",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11287",
"triggerID" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"triggerType" : "PUSH"
}, {
"hash" : "da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2b4d901d51c87824302397aa6059fc255ce57f9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223)
* 8b758a6aa9c3f9e5f7a053096816f186f7d39ee0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11287)
* da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "750035011",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11287",
"triggerID" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2b4d901d51c87824302397aa6059fc255ce57f9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223)
* 8b758a6aa9c3f9e5f7a053096816f186f7d39ee0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11287)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8ee08bbbe2d3830f129c85472780136a72ece8f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "750035011",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11287",
"triggerID" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"triggerType" : "PUSH"
}, {
"hash" : "da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11292",
"triggerID" : "da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8b758a6aa9c3f9e5f7a053096816f186f7d39ee0 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11287)
* da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] meijies removed a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
meijies removed a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749676427
@flinkbot run travis
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "750035011",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11287",
"triggerID" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"triggerType" : "PUSH"
}, {
"hash" : "da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11292",
"triggerID" : "da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749665549
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 5783446335d3f812edd6d58ee643b5f6a312c0e0 (Tue Dec 22 17:11:29 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "750035011",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11287",
"triggerID" : "8b758a6aa9c3f9e5f7a053096816f186f7d39ee0",
"triggerType" : "PUSH"
}, {
"hash" : "da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11292",
"triggerID" : "da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d2b4d901d51c87824302397aa6059fc255ce57f9 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223)
* 8b758a6aa9c3f9e5f7a053096816f186f7d39ee0 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11287)
* da6a0ddddc1b4a1ca4cf31cfe869c7e121185c21 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11292)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14468:
URL: https://github.com/apache/flink/pull/14468#discussion_r548414934
##########
File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSinkITCase.java
##########
@@ -316,4 +338,39 @@ public void testReadingFromChangelogSource() throws Exception {
Row.of("user4", "Tina", "tina@gmail.com", new BigDecimal("11.30"), new BigDecimal("22.60"))
}, DB_URL, USER_TABLE, new String[]{"user_id", "user_name", "email", "balance", "balance2"});
}
+
+ @Test
+ public void testCheckpoint() throws Exception {
Review comment:
Rename to `testFlushBufferWhenCheckpoint` to make the test purpose more explicitly.
##########
File path: flink-connectors/flink-connector-jdbc/pom.xml
##########
@@ -109,6 +109,14 @@ under the License.
<!-- Postgres test dependencies -->
+ <dependency>
Review comment:
Move this after comment `<!-- test dependencies -->` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] meijies commented on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
meijies commented on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749676427
@flinkbot run travis
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-750797269
Btw, please avoid merge commits in the next time. It is suggested to use `git rebase` instead of `git pull` or `git merge` to rebase development branch to master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "750035011",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* d2b4d901d51c87824302397aa6059fc255ce57f9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11223)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14468: [FLINK-20552][connectors/jdbc] JdbcDynamicTableSink doesn't sink buff…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14468:
URL: https://github.com/apache/flink/pull/14468#issuecomment-749674915
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11200",
"triggerID" : "8ee08bbbe2d3830f129c85472780136a72ece8f3",
"triggerType" : "PUSH"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "749973352",
"triggerType" : "MANUAL"
}, {
"hash" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d2b4d901d51c87824302397aa6059fc255ce57f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* d2b4d901d51c87824302397aa6059fc255ce57f9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org