[GitHub] [hudi] danny0405 commented on a diff in pull request #9558: [HUDI-6481] Support run multi tables services in a single spark job

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #9558:
URL: https://github.com/apache/hudi/pull/9558#discussion_r1315314496


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCleaner.java:
##########
@@ -64,6 +64,13 @@ public HoodieCleaner(Config cfg, JavaSparkContext jssc) {
     LOG.info("Creating Cleaner with configs : " + props.toString());
   }
 
+  public HoodieCleaner(Config cfg, TypedProperties props, JavaSparkContext jssc) {
+    this.cfg = cfg;
+    this.jssc = jssc;
+    this.props = props;

Review Comment:
   The original code fetches the props either from cmd line or global options, what is the purpose to support custom props per-service then?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org