You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/01/06 12:53:54 UTC
[GitHub] carbondata pull request #1770: [CARBONDATA-1994] Remove CarbonInputFormat
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/1770
[CARBONDATA-1994] Remove CarbonInputFormat
Currently CarbonData is implemented as table level file format, which is read by CarbonTableInputFormat. CarbonInputFormat is obsoleted and it should be not used any more. This PR deleted it. It will be implemented in [CARBONDATA-1995](https://issues.apache.org/jira/browse/CARBONDATA-1995).
- [X] Any interfaces changed?
No
- [X] Any backward compatibility impacted?
No
- [X] Document update required?
No
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata remove_carboninputformat
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1770.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1770
----
commit 7947aaf150a9c1d62dc8ae1e1c7586f96d503972
Author: Jacky Li <ja...@...>
Date: 2018-01-06T12:45:24Z
remove CarbonInputFormat
----
---
[GitHub] carbondata pull request #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1770
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2699/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2616/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1770
retest this please
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2608/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2690/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1770
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2861/
---
[GitHub] carbondata pull request #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by mohammadshahidkhan <gi...@git.apache.org>.
Github user mohammadshahidkhan commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1770#discussion_r161200792
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dblocation/DBLocationCarbonTableTestCase.scala ---
@@ -44,6 +44,24 @@ class DBLocationCarbonTableTestCase extends QueryTest with BeforeAndAfterAll {
sql("drop database if exists carbon cascade")
}
+ //TODO fix this test case
+ test("Update operation on carbon table with insert into") {
--- End diff --
I think here only the method got placed from one place to another no code change
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1466/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1770
@ravipesala I have fixed it now
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2662/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1373/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2686/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1770
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2772/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1452/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1770
@jackylk seems one test case in 2.2.1 is always failing, please check
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1428/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1502/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1381/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1770
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2804/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1770
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2779/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1770
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2823/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2734/
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1770
LGTM
---
[GitHub] carbondata pull request #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1770#discussion_r161228361
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/dblocation/DBLocationCarbonTableTestCase.scala ---
@@ -44,6 +44,24 @@ class DBLocationCarbonTableTestCase extends QueryTest with BeforeAndAfterAll {
sql("drop database if exists carbon cascade")
}
+ //TODO fix this test case
+ test("Update operation on carbon table with insert into") {
--- End diff --
yes, I think this testcase fails sometimes because of the order, I change the order of the testcase to avoid the failure.
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1770
retest this please
---
[GitHub] carbondata issue #1770: [CARBONDATA-1994] Remove CarbonInputFormat
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1770
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1455/
---