You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/06/01 18:29:00 UTC

[GitHub] [incubator-livy] wypoon commented on pull request #296: [LIVY-771][THRIFT] Do not remove trailing zeros from decimal values.

wypoon commented on pull request #296:
URL: https://github.com/apache/incubator-livy/pull/296#issuecomment-637030336


   Hi @mgaido91 , I have responded to your point about negative scale in the decimal type in Spark SQL, and addressed the nit about the comment in the ColumnBufferTest. I have also clarified the Jira description and the PR description. This is a simple but important fix. Can we move forward now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org