You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/10 15:45:09 UTC

[GitHub] [kylin] xiacongling opened a new pull request #1157: KYLIN-4423 use spring session to support clustered sessions

xiacongling opened a new pull request #1157: KYLIN-4423 use spring session to support clustered sessions
URL: https://github.com/apache/kylin/pull/1157
 
 
   add spring session to manage user sessions, one can define a proper SessionRepository to enable it. for Redis repository, the following dependencies and spring bean can be added:
   ```
   <!-- dependencies with best compatible version, add it to pom.xml -->
   <dependency>
       <groupId>org.springframework.data</groupId>
       <artifactId>spring-data-redis</artifactId>
       <version>1.8.6.RELEASE</version>
   </dependency>
   <dependency>
       <groupId>redis.clients</groupId>
       <artifactId>jedis</artifactId>
       <version>2.9.3</version>
   </dependency>
   
   <!-- spring beans to add in applicationContext.xml -->
   <bean id="redisConnectionFactory"
         class="org.springframework.data.redis.connection.jedis.JedisConnectionFactory">
       <property name="hostName" value="${kylin.session.redis.host:127.0.0.1}"/>
       <property name="port" value="${kylin.session.redis.port:6379}"/>
   </bean>
   <bean id="redisSessionRepository"
         class="org.springframework.session.data.redis.RedisOperationsSessionRepository">
       <constructor-arg index="0" ref="redisConnectionFactory"/>
   </bean>
   ```
   see also: https://issues.apache.org/jira/browse/KYLIN-4423

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1157: KYLIN-4423 use spring session to support clustered sessions

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1157: KYLIN-4423 use spring session to support clustered sessions
URL: https://github.com/apache/kylin/pull/1157#issuecomment-597203624
 
 
   ## Pull Request Test Coverage Report for [Build 5771](https://coveralls.io/builds/29423040)
   
   * **13** of **42**   **(30.95%)**  changed or added relevant lines in **2** files are covered.
   * **3** unchanged lines in **1** file lost coverage.
   * Overall coverage increased (+**0.006%**) to **27.52%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [server-base/src/main/java/org/apache/kylin/rest/session/KylinSessionFilter.java](https://coveralls.io/builds/29423040/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionFilter.java#L43) | 4 | 12 | 33.33%
   | [server-base/src/main/java/org/apache/kylin/rest/session/KylinSessionConfig.java](https://coveralls.io/builds/29423040/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionConfig.java#L66) | 9 | 30 | 30.0%
   <!-- | **Total:** | **13** | **42** | **30.95%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29423040/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
   <!-- | **Total:** | **3** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29423040/badge)](https://coveralls.io/builds/29423040) |
   | :-- | --: |
   | Change from base [Build 5753](https://coveralls.io/builds/29295116): |  0.006% |
   | Covered Lines: | 24313 |
   | Relevant Lines: | 88347 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1157: KYLIN-4423 use spring session to support clustered sessions

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1157: KYLIN-4423 use spring session to support clustered sessions
URL: https://github.com/apache/kylin/pull/1157#issuecomment-597203624
 
 
   ## Pull Request Test Coverage Report for [Build 5738](https://coveralls.io/builds/29254801)
   
   * **13** of **42**   **(30.95%)**  changed or added relevant lines in **2** files are covered.
   * **2** unchanged lines in **2** files lost coverage.
   * Overall coverage increased (+**0.0005%**) to **27.519%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [server-base/src/main/java/org/apache/kylin/rest/session/KylinSessionFilter.java](https://coveralls.io/builds/29254801/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionFilter.java#L43) | 4 | 12 | 33.33%
   | [server-base/src/main/java/org/apache/kylin/rest/session/KylinSessionConfig.java](https://coveralls.io/builds/29254801/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionConfig.java#L66) | 9 | 30 | 30.0%
   <!-- | **Total:** | **13** | **42** | **30.95%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-dictionary/src/main/java/org/apache/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://coveralls.io/builds/29254801/source?filename=core-dictionary%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fdict%2Flookup%2Fcache%2FRocksDBLookupTable.java#L62) | 1 | 81.08% |
   | [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/29254801/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L146) | 1 | 56.82% |
   <!-- | **Total:** | **2** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29254801/badge)](https://coveralls.io/builds/29254801) |
   | :-- | --: |
   | Change from base [Build 5720](https://coveralls.io/builds/29194855): |  0.0005% |
   | Covered Lines: | 24312 |
   | Relevant Lines: | 88347 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1157: KYLIN-4423 use spring session to support clustered sessions

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1157: KYLIN-4423 use spring session to support clustered sessions
URL: https://github.com/apache/kylin/pull/1157#issuecomment-604596756
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=h1) Report
   > Merging [#1157](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/b61d4989a842c06f993e9a3df75262c764972589&el=desc) will **decrease** coverage by `0.04%`.
   > The diff coverage is `28.57%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1157/graphs/tree.svg?width=650&height=150&src=pr&token=JawVgbgsVo)](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1157      +/-   ##
   ============================================
   - Coverage     25.06%   25.02%   -0.05%     
   - Complexity     6248     6258      +10     
   ============================================
     Files          1446     1451       +5     
     Lines         88305    88540     +235     
     Branches      12357    12379      +22     
   ============================================
   + Hits          22131    22154      +23     
   - Misses        64004    64211     +207     
   - Partials       2170     2175       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../apache/kylin/rest/session/KylinSessionConfig.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2Vzc2lvbi9LeWxpblNlc3Npb25Db25maWcuamF2YQ==) | `26.66% <26.66%> (ø)` | `2.00 <2.00> (?)` | |
   | [.../apache/kylin/rest/session/KylinSessionFilter.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2Vzc2lvbi9LeWxpblNlc3Npb25GaWx0ZXIuamF2YQ==) | `33.33% <33.33%> (ø)` | `4.00 <4.00> (?)` | |
   | [...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==) | `72.97% <0.00%> (-5.41%)` | `6.00% <0.00%> (-1.00%)` | |
   | [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0.00%> (-0.92%)` | `7.00% <0.00%> (ø%)` | |
   | [...he/kylin/engine/mr/common/MapReduceExecutable.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL01hcFJlZHVjZUV4ZWN1dGFibGUuamF2YQ==) | `12.91% <0.00%> (-0.42%)` | `6.00% <0.00%> (ø%)` | |
   | [...c/main/java/org/apache/kylin/cube/CubeManager.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL0N1YmVNYW5hZ2VyLmphdmE=) | `36.50% <0.00%> (-0.12%)` | `44.00% <0.00%> (ø%)` | |
   | [...n/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9EaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...ava/org/apache/kylin/tool/JobDiagnosisInfoCLI.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-dG9vbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vdG9vbC9Kb2JEaWFnbm9zaXNJbmZvQ0xJLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [.../java/org/apache/kylin/common/util/HadoopUtil.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi91dGlsL0hhZG9vcFV0aWwuamF2YQ==) | `14.56% <0.00%> (ø)` | `10.00% <0.00%> (ø%)` | |
   | [...rg/apache/kylin/rest/service/DiagnosisService.java](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9EaWFnbm9zaXNTZXJ2aWNlLmphdmE=) | `26.78% <0.00%> (ø)` | `6.00% <0.00%> (ø%)` | |
   | ... and [27 more](https://codecov.io/gh/apache/kylin/pull/1157/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=footer). Last update [b61d498...cba5515](https://codecov.io/gh/apache/kylin/pull/1157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls edited a comment on issue #1157: KYLIN-4423 use spring session to support clustered sessions

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #1157: KYLIN-4423 use spring session to support clustered sessions
URL: https://github.com/apache/kylin/pull/1157#issuecomment-597203624
 
 
   ## Pull Request Test Coverage Report for [Build 5789](https://coveralls.io/builds/29641513)
   
   * **13** of **42**   **(30.95%)**  changed or added relevant lines in **2** files are covered.
   * **344** unchanged lines in **9** files lost coverage.
   * Overall coverage decreased (**-0.03%**) to **27.481%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [server-base/src/main/java/org/apache/kylin/rest/session/KylinSessionFilter.java](https://coveralls.io/builds/29641513/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionFilter.java#L43) | 4 | 12 | 33.33%
   | [server-base/src/main/java/org/apache/kylin/rest/session/KylinSessionConfig.java](https://coveralls.io/builds/29641513/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fsession%2FKylinSessionConfig.java#L66) | 9 | 30 | 30.0%
   <!-- | **Total:** | **13** | **42** | **30.95%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/CreateDictionaryJob.java](https://coveralls.io/builds/29641513/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FCreateDictionaryJob.java#L85) | 1 | 0% |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/29641513/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L449) | 3 | 78.42% |
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/common/MapReduceExecutable.java](https://coveralls.io/builds/29641513/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fcommon%2FMapReduceExecutable.java#L496) | 3 | 14.76% |
   | [server-base/src/main/java/org/apache/kylin/rest/service/DiagnosisService.java](https://coveralls.io/builds/29641513/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Fservice%2FDiagnosisService.java#L102) | 5 | 32.14% |
   | [core-common/src/main/java/org/apache/kylin/common/util/ToolUtil.java](https://coveralls.io/builds/29641513/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FToolUtil.java#L38) | 18 | 21.28% |
   | [core-common/src/main/java/org/apache/kylin/common/util/HadoopUtil.java](https://coveralls.io/builds/29641513/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2Futil%2FHadoopUtil.java#L85) | 40 | 18.45% |
   | [tool/src/main/java/org/apache/kylin/tool/JobDiagnosisInfoCLI.java](https://coveralls.io/builds/29641513/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FJobDiagnosisInfoCLI.java#L49) | 41 | 0% |
   | [tool/src/main/java/org/apache/kylin/tool/DiagnosisInfoCLI.java](https://coveralls.io/builds/29641513/source?filename=tool%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Ftool%2FDiagnosisInfoCLI.java#L59) | 77 | 0% |
   | [core-cube/src/main/java/org/apache/kylin/cube/CubeManager.java](https://coveralls.io/builds/29641513/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2FCubeManager.java#L166) | 156 | 41.59% |
   <!-- | **Total:** | **344** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29641513/badge)](https://coveralls.io/builds/29641513) |
   | :-- | --: |
   | Change from base [Build 5753](https://coveralls.io/builds/29295116): |  -0.03% |
   | Covered Lines: | 24332 |
   | Relevant Lines: | 88540 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services