You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "fuweng11 (via GitHub)" <gi...@apache.org> on 2023/04/20 13:01:43 UTC
[GitHub] [inlong] fuweng11 opened a new pull request, #7884: [INLONG-7883][Manager] Invalidate user session when deleting user
fuweng11 opened a new pull request, #7884:
URL: https://github.com/apache/inlong/pull/7884
### Prepare a Pull Request
- Fixes #7883
### Motivation
Invalidate user session when deleting user.
### Modifications
Invalidate user session when deleting user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang merged pull request #7884: [INLONG-7883][Manager] Invalidate user session when deleting user
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7884:
URL: https://github.com/apache/inlong/pull/7884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on pull request #7884: [INLONG-7883][Manager] Invalidate user session when deleting user
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on PR #7884:
URL: https://github.com/apache/inlong/pull/7884#issuecomment-1517227213
We need to consider a way to manage user information in a distributed manner. After deleting a user, all sessions in the Manager service will be invalidated.
My idea is, without the use of three-party components, can we cache user info in the memory of the Manager service, synchronize it from the DB regularly, and remove the session when the user data in the DB is found to be invalid.
In this way, all Manager services can be synchronized within a certain period of time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7884: [INLONG-7883][Manager] Invalidate user session when deleting user
Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7884:
URL: https://github.com/apache/inlong/pull/7884#discussion_r1173279504
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/UserServiceImpl.java:
##########
@@ -460,4 +466,28 @@ public void removeInChargeForConsume(String user, String operator) {
}
}
+ public void removeUserFromSession(Integer userId, String operator) {
Review Comment:
In the scenario of a single Manager service, this modification takes effect.
However, when multiple Manager services are deployed, this modification cannot take effect globally.
Approve first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org