You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/11/07 00:41:04 UTC
[GitHub] [fineract] vorburger opened a new pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
vorburger opened a new pull request #1495:
URL: https://github.com/apache/fineract/pull/1495
related to, but doesn't solve, Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-729679765
@avikganguly01 do you think it's useful to have INFO logs and has any real world in your logstash? My experience in running Fineract.dev and using Google Error Reporting has been that all I ever look at and seem to care about is WARN and ERROR... (BTW note all the issues linked from FINERACT-932 which I've been able to find! Do you want to contribute fixes for some of them?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-723541013
I thought about this, and while using it actually started liking it better like this, it's suddenly so... "quiet, and clean"! ;-) It also "feels" like it's "lighter" and"starts faster", although that's just "perception", of course. But YMMV. It's a bit like Maven (which verbosely logs everything it's doing) VS Gradle (which spews less logs). This also feels like it's more inline with our https://github.com/apache/fineract#logging-guidelines, notably the point about log levels. So my vote is on just changing this generally, not just for ITs, but I'm interested in how others feel about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-727156150
I understand this does not resolve https://issues.apache.org/jira/browse/FINERACT-1168 but I think this change only looks good if we can get https://issues.apache.org/jira/browse/FINERACT-764. So, just a thought instead having a foreplay with this logging why not just package it with https://github.com/apache/fineract/pull/1444 or bring it in after.
But overall, I think it's a good fit though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] avikganguly01 commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
avikganguly01 commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-729676885
@vorburger : Logstash scripts in some older implementations will break if we upgrade but that's fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-723521048
Just wondering... do we want to make this the default behaviour? Or just something that is used when running integration tests? I personally think seeing the INFO would be OK as normal behaviour (as that's what people would expect to see from other Spring Boot apps) - and we would just turn it off for Integration Tests. But not sure how easy that is to achieve?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-753411302
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1495:
URL: https://github.com/apache/fineract/pull/1495
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-726300284
What do other recently active commiters think re this - pro or con? @vidakovic @avikganguly01 @fynmanoj @percyashu @awasum
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-761788963
FINERACT-1295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-774677092
I'm "self merging" this, given that nobody objected on https://lists.apache.org/thread.html/r9e3de9996a7f9f1bd49615b5a7d44f6c8daeca5cbccdac2967233bbd%40%3Cdev.fineract.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1495: Log only WARN & ERR but not INFO anymore (re. FINERACT-1168)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1495:
URL: https://github.com/apache/fineract/pull/1495#issuecomment-737181473
@vorburger just to be clear, I'm happy either way... haven't tried this to see how much cleaner it is, but at the same time I don't think there's a huge amount of useful information in the INFO logging either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org