You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/09/21 14:35:46 UTC
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #208: [YUNIKORN-335] - schema check added
codecov[bot] commented on pull request #208:
URL: https://github.com/apache/incubator-yunikorn-core/pull/208#issuecomment-696156986
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208?src=pr&el=h1) Report
> Merging [#208](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/c2699e725c8a0f89fbcd7618908ad4cf712227e9?el=desc) will **decrease** coverage by `0.43%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 61.24% 60.80% -0.44%
==========================================
Files 67 67
Lines 6618 5687 -931
==========================================
- Hits 4053 3458 -595
+ Misses 2420 2087 -333
+ Partials 145 142 -3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/cache/partition\_info.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL3BhcnRpdGlvbl9pbmZvLmdv) | `72.48% <100.00%> (-0.09%)` | :arrow_down: |
| [pkg/common/configs/config.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZy5nbw==) | `68.96% <100.00%> (-2.91%)` | :arrow_down: |
| [pkg/webservice/handlers.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL3dlYnNlcnZpY2UvaGFuZGxlcnMuZ28=) | `47.53% <100.00%> (-0.69%)` | :arrow_down: |
| [pkg/common/configs/configtestutils.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3Rlc3R1dGlscy5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `88.88% <0.00%> (-11.12%)` | :arrow_down: |
| [pkg/metrics/metrics\_collector.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL21ldHJpY3MvbWV0cmljc19jb2xsZWN0b3IuZ28=) | `73.91% <0.00%> (-4.66%)` | :arrow_down: |
| [pkg/scheduler/scheduling\_allocation\_ask.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL3NjaGVkdWxlci9zY2hlZHVsaW5nX2FsbG9jYXRpb25fYXNrLmdv) | `54.05% <0.00%> (-4.09%)` | :arrow_down: |
| [pkg/log/logger.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dnZXIuZ28=) | `80.00% <0.00%> (-2.50%)` | :arrow_down: |
| [pkg/cache/initializer.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL2NhY2hlL2luaXRpYWxpemVyLmdv) | `78.82% <0.00%> (-2.43%)` | :arrow_down: |
| [pkg/plugins/plugins.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree#diff-cGtnL3BsdWdpbnMvcGx1Z2lucy5nbw==) | `72.72% <0.00%> (-2.28%)` | :arrow_down: |
| ... and [60 more](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208?src=pr&el=footer). Last update [ee4ea3e...faf9a11](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/208?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org