You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2020/01/16 04:30:04 UTC
[spark] branch branch-2.4 updated: Revert "[SPARK-27868][CORE]
Better default value and documentation for socket server backlog."
This is an automated email from the ASF dual-hosted git repository.
dongjoon pushed a commit to branch branch-2.4
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-2.4 by this push:
new 94b5d3fd Revert "[SPARK-27868][CORE] Better default value and documentation for socket server backlog."
94b5d3fd is described below
commit 94b5d3fd64ea5498b19f9ea7aacb484a18496018
Author: Dongjoon Hyun <dh...@apple.com>
AuthorDate: Wed Jan 15 20:27:18 2020 -0800
Revert "[SPARK-27868][CORE] Better default value and documentation for socket server backlog."
This reverts commit 84bd8085c74b5292cdccaa287023e39703062b07.
---
.../apache/spark/network/server/TransportServer.java | 2 --
.../org/apache/spark/network/util/TransportConf.java | 4 ++--
docs/configuration.md | 20 --------------------
3 files changed, 2 insertions(+), 24 deletions(-)
diff --git a/common/network-common/src/main/java/org/apache/spark/network/server/TransportServer.java b/common/network-common/src/main/java/org/apache/spark/network/server/TransportServer.java
index 71ea787..9c85ab2 100644
--- a/common/network-common/src/main/java/org/apache/spark/network/server/TransportServer.java
+++ b/common/network-common/src/main/java/org/apache/spark/network/server/TransportServer.java
@@ -123,8 +123,6 @@ public class TransportServer implements Closeable {
bootstrap.childHandler(new ChannelInitializer<SocketChannel>() {
@Override
protected void initChannel(SocketChannel ch) {
- logger.debug("New connection accepted for remote address {}.", ch.remoteAddress());
-
RpcHandler rpcHandler = appRpcHandler;
for (TransportServerBootstrap bootstrap : bootstraps) {
rpcHandler = bootstrap.doBootstrap(ch, rpcHandler);
diff --git a/common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java b/common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
index 4b20583..34e4bb5 100644
--- a/common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
+++ b/common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
@@ -105,8 +105,8 @@ public class TransportConf {
return conf.getInt(SPARK_NETWORK_IO_NUMCONNECTIONSPERPEER_KEY, 1);
}
- /** Requested maximum length of the queue of incoming connections. Default is 64. */
- public int backLog() { return conf.getInt(SPARK_NETWORK_IO_BACKLOG_KEY, 64); }
+ /** Requested maximum length of the queue of incoming connections. Default -1 for no backlog. */
+ public int backLog() { return conf.getInt(SPARK_NETWORK_IO_BACKLOG_KEY, -1); }
/** Number of threads used in the server thread pool. Default to 0, which is 2x#cores. */
public int serverThreads() { return conf.getInt(SPARK_NETWORK_IO_SERVERTHREADS_KEY, 0); }
diff --git a/docs/configuration.md b/docs/configuration.md
index 4db0ea6..b736d0c 100644
--- a/docs/configuration.md
+++ b/docs/configuration.md
@@ -659,17 +659,6 @@ Apart from these, the following properties are also available, and may be useful
</td>
</tr>
<tr>
- <td><code>spark.shuffle.io.backLog</code></td>
- <td>64</td>
- <td>
- Length of the accept queue for the shuffle service. For large applications, this value may
- need to be increased, so that incoming connections are not dropped if the service cannot keep
- up with a large number of connections arriving in a short period of time. This needs to
- be configured wherever the shuffle service itself is running, which may be outside of the
- application (see <code>spark.shuffle.service.enabled</code> option below).
- </td>
-</tr>
-<tr>
<td><code>spark.shuffle.service.enabled</code></td>
<td>false</td>
<td>
@@ -1480,15 +1469,6 @@ Apart from these, the following properties are also available, and may be useful
</td>
</tr>
<tr>
- <td><code>spark.rpc.io.backLog</code></td>
- <td>64</td>
- <td>
- Length of the accept queue for the RPC server. For large applications, this value may
- need to be increased, so that incoming connections are not dropped when a large number of
- connections arrives in a short period of time.
- </td>
-</tr>
-<tr>
<td><code>spark.network.timeout</code></td>
<td>120s</td>
<td>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org