[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1816: Fix Decimal and List ArrayData Validation (#1813) (#1814)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #1816:
URL: https://github.com/apache/arrow-rs/pull/1816#discussion_r891566825


##########
arrow/src/array/data.rs:
##########
@@ -738,40 +738,47 @@ impl ArrayData {
     /// entries.
     ///
     /// For an empty array, the `buffer` can also be empty.
-    fn typed_offsets<'a, T: ArrowNativeType + num::Num + std::fmt::Display>(
-        &'a self,
-        buffer: &'a Buffer,
-    ) -> Result<&'a [T]> {
+    fn typed_offsets<T: ArrowNativeType + num::Num>(&self) -> Result<&[T]> {

Review Comment:
   I found the way this accepted a buffer, but then used information from self to interpret that data, deeply confusing. I therefore changed this 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org