[GitHub] [incubator-nuttx] donghengqaz commented on pull request #1435: ESP32: Add driver support to I2C

[GitBox <gi...@apache.org>]

donghengqaz commented on pull request #1435:
URL: https://github.com/apache/incubator-nuttx/pull/1435#issuecomment-661596710


   > HI, Then the headers should be like this as specified in the the Apache license appendix. Copyright [yyyy] [name of copyright owner] Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. This is important and it needs to be correctly handled. Any code coming from 3rd parties should not have the ASF header on it until it has been accepted in a software grant and all the ICLAs signed. Also if they have a NOTICE file then you would also need to look at that and move some of it content to our NOTICE file. Thanks, Justin
   
   I bring the header file from esp-idf and add more macros to it to make it more applicable to Nuttx, so it is not the origin one, it is a new one based on the esp-idf's header file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org