[GitHub] [iceberg] stevenzwu commented on a diff in pull request #7403: Flink: sync 1.16 with 1.17 for backports missed or not ported identically

["stevenzwu (via GitHub)" <gi...@apache.org>]

stevenzwu commented on code in PR #7403:
URL: https://github.com/apache/iceberg/pull/7403#discussion_r1175654693


##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/source/RowDataFileScanTaskReader.java:
##########
@@ -59,14 +58,8 @@ public class RowDataFileScanTaskReader implements FileScanTaskReader<RowData> {
   private final Schema projectedSchema;
   private final String nameMapping;
   private final boolean caseSensitive;
-
   private final FlinkSourceFilter rowFilter;
 
-  public RowDataFileScanTaskReader(

Review Comment:
   thx for the context. `RowDataFileScanTaskReader` is marked as `@Internal`. Users don't construct it directly. it should be only used internally. Hence I think it is better to keep it the same across versions.
   
   <img width="449" alt="image" src="https://user-images.githubusercontent.com/1545663/234086006-04a1b4b0-d575-4280-a632-2f899ffa4a5a.png">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org