You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pranav Saxena <pr...@citrix.com> on 2013/04/09 13:59:03 UTC
FW: git commit: updated refs/heads/4.1 to 9b6ff74
Hi Chip,
I had to make a small commit to 4.1 without creating a patch request for it . The fix would allow the user to see the instance UUID under the load balancer rule when it's "displayname" property is NULL since prior to this nothing was displayed which was blocking the user to know which instance is associated with the lb Rule.
Thanks,
Pranav
-----Original Message-----
From: pranavs@apache.org [mailto:pranavs@apache.org]
Sent: Tuesday, April 09, 2013 5:26 PM
To: commits@cloudstack.apache.org
Subject: git commit: updated refs/heads/4.1 to 9b6ff74
Updated Branches:
refs/heads/4.1 6d2a24680 -> 9b6ff74e3
CLOUDSTACK-1428:[UI] Instance which are created without display name are not visible when added to LB: Using the name property instead in the data flow
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/9b6ff74e
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/9b6ff74e
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/9b6ff74e
Branch: refs/heads/4.1
Commit: 9b6ff74e3a9535dddfe88121afcfa49cca546cf2
Parents: 6d2a246
Author: Pranav Saxena <pr...@citrix.com>
Authored: Tue Apr 9 17:03:41 2013 +0530
Committer: Pranav Saxena <pr...@citrix.com>
Committed: Tue Apr 9 17:03:41 2013 +0530
----------------------------------------------------------------------
ui/scripts/network.js | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/9b6ff74e/ui/scripts/network.js
----------------------------------------------------------------------
diff --git a/ui/scripts/network.js b/ui/scripts/network.js index db06c04..1bc4eba 100755
--- a/ui/scripts/network.js
+++ b/ui/scripts/network.js
@@ -3099,7 +3099,7 @@
});
$.extend(item, {
- _itemName: 'displayname',
+ _itemName: 'name',
_itemData: lbInstances,
_maxLength: {
name: 7
Re: FW: git commit: updated refs/heads/4.1 to 9b6ff74
Posted by Chip Childers <ch...@sungard.com>.
On Tue, Apr 09, 2013 at 11:59:03AM +0000, Pranav Saxena wrote:
> Hi Chip,
>
> I had to make a small commit to 4.1 without creating a patch request for it . The fix would allow the user to see the instance UUID under the load balancer rule when it's "displayname" property is NULL since prior to this nothing was displayed which was blocking the user to know which instance is associated with the lb Rule.
>
ACK - thanks for the note. Looks fine.
> Thanks,
> Pranav
>
> -----Original Message-----
> From: pranavs@apache.org [mailto:pranavs@apache.org]
> Sent: Tuesday, April 09, 2013 5:26 PM
> To: commits@cloudstack.apache.org
> Subject: git commit: updated refs/heads/4.1 to 9b6ff74
>
> Updated Branches:
> refs/heads/4.1 6d2a24680 -> 9b6ff74e3
>
>
> CLOUDSTACK-1428:[UI] Instance which are created without display name are not visible when added to LB: Using the name property instead in the data flow
>
>
> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
> Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/9b6ff74e
> Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/9b6ff74e
> Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/9b6ff74e
>
> Branch: refs/heads/4.1
> Commit: 9b6ff74e3a9535dddfe88121afcfa49cca546cf2
> Parents: 6d2a246
> Author: Pranav Saxena <pr...@citrix.com>
> Authored: Tue Apr 9 17:03:41 2013 +0530
> Committer: Pranav Saxena <pr...@citrix.com>
> Committed: Tue Apr 9 17:03:41 2013 +0530
>
> ----------------------------------------------------------------------
> ui/scripts/network.js | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/cloudstack/blob/9b6ff74e/ui/scripts/network.js
> ----------------------------------------------------------------------
> diff --git a/ui/scripts/network.js b/ui/scripts/network.js index db06c04..1bc4eba 100755
> --- a/ui/scripts/network.js
> +++ b/ui/scripts/network.js
> @@ -3099,7 +3099,7 @@
> });
>
> $.extend(item, {
> - _itemName: 'displayname',
> + _itemName: 'name',
> _itemData: lbInstances,
> _maxLength: {
> name: 7
>
>