[GitHub] [superset] ad-m commented on pull request #18200: chore: upgrade BoundsControl to TS

[GitBox <gi...@apache.org>]

ad-m commented on pull request #18200:
URL: https://github.com/apache/superset/pull/18200#issuecomment-1023476917


   > One suggestion for you, I'd say that smaller contributions are good but in order to keep things together and avoid fragmentation, we could group more work under one PR. For instance, what do you think about converting this component to a functional one? This PR seems the perfect place to do that!
   
   I will convert it to FC. I can do it in this PR, and I can do it separately - as you prefer. I am open to doing whatever it takes to ensure that the review works efficiently and the work of the commiters is minimized.
   
   I can see that this is not a technically attractive issue (but long-term important for the condition of the project, so perfect for someone who is just getting to know the structure of the project, like me), so it's harder to get a voluntary review, so I'm afraid that PR's like that will not get stuck. For reasons external to the project (personal), such a state of the matter would be uncomfortable for me, and small steps are always something forward.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org