[GitHub] [commons-lang] yichinzhu commented on pull request #1100: Fix ThresholdCircuitBreaker

["yichinzhu (via GitHub)" <gi...@apache.org>]

yichinzhu commented on PR #1100:
URL: https://github.com/apache/commons-lang/pull/1100#issuecomment-1690917469

   > -1, the docs read "**true** means that the circuit breaker is currently open"
   
   The comments in CircuitBreaker.java shows that "The return value indicates whether the circuit breaker is now in state closed a value  of true typically means that the current operation can continue." .
   And EventCountCircuitBreaker also returns true for CLOSED state as an implementation
   
   links:
   
   https://github.com/apache/commons-lang/blob/2fb38b1bb76a0a33d72864c8e39b536bce6b39e7/src/main/java/org/apache/commons/lang3/concurrent/CircuitBreaker.java#L61-L68
   
   https://github.com/apache/commons-lang/blob/2fb38b1bb76a0a33d72864c8e39b536bce6b39e7/src/main/java/org/apache/commons/lang3/concurrent/EventCountCircuitBreaker.java#L336
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org