You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/03/26 07:26:31 UTC
[GitHub] [incubator-pinot] codecov-io edited a comment on issue #4914: [POC]
By-passing deep-store requirement for Realtime segment completion
codecov-io edited a comment on issue #4914: [POC] By-passing deep-store requirement for Realtime segment completion
URL: https://github.com/apache/incubator-pinot/pull/4914#issuecomment-564796350
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4914?src=pr&el=h1) Report
> Merging [#4914](https://codecov.io/gh/apache/incubator-pinot/pull/4914?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/28f264352f10481adce90c838a2db7de196a2c58&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `85.43%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4914?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4914 +/- ##
============================================
+ Coverage 66.09% 66.16% +0.07%
Complexity 12 12
============================================
Files 1052 1053 +1
Lines 54170 54298 +128
Branches 8078 8093 +15
============================================
+ Hits 35801 35925 +124
- Misses 15714 15715 +1
- Partials 2655 2658 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4914?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `40.81% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/data/manager/realtime/SplitSegmentCommitter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvU3BsaXRTZWdtZW50Q29tbWl0dGVyLmphdmE=) | `60.71% <57.14%> (ø)` | `0.00 <0.00> (ø)` | |
| [...common/utils/fetcher/PeerServerSegmentFetcher.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvZmV0Y2hlci9QZWVyU2VydmVyU2VnbWVudEZldGNoZXIuamF2YQ==) | `78.43% <78.43%> (ø)` | `0.00 <0.00> (?)` | |
| [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `71.57% <78.94%> (+2.33%)` | `0.00 <0.00> (ø)` | |
| [...ot/common/utils/fetcher/SegmentFetcherFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvZmV0Y2hlci9TZWdtZW50RmV0Y2hlckZhY3RvcnkuamF2YQ==) | `88.88% <85.71%> (-0.59%)` | `0.00 <0.00> (ø)` | |
| [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `68.98% <88.46%> (+17.87%)` | `0.00 <0.00> (ø)` | |
| [...ot/common/protocols/SegmentCompletionProtocol.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcHJvdG9jb2xzL1NlZ21lbnRDb21wbGV0aW9uUHJvdG9jb2wuamF2YQ==) | `94.24% <100.00%> (+0.18%)` | `0.00 <0.00> (ø)` | |
| [...er/api/resources/LLCSegmentCompletionHandlers.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9hcGkvcmVzb3VyY2VzL0xMQ1NlZ21lbnRDb21wbGV0aW9uSGFuZGxlcnMuamF2YQ==) | `61.80% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [.../core/realtime/PinotLLCRealtimeSegmentManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1Bpbm90TExDUmVhbHRpbWVTZWdtZW50TWFuYWdlci5qYXZh) | `74.53% <100.00%> (-0.06%)` | `0.00 <0.00> (ø)` | |
| [.../helix/core/realtime/SegmentCompletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3JlYWx0aW1lL1NlZ21lbnRDb21wbGV0aW9uTWFuYWdlci5qYXZh) | `71.76% <100.00%> (+1.12%)` | `0.00 <0.00> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/incubator-pinot/pull/4914/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4914?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4914?src=pr&el=footer). Last update [28f2643...0468925](https://codecov.io/gh/apache/incubator-pinot/pull/4914?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org