You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/12 07:54:44 UTC

[GitHub] [pulsar] cbornet commented on pull request #15122: Add a cache of versioned KeyValueSchemaImpl

cbornet commented on PR #15122:
URL: https://github.com/apache/pulsar/pull/15122#issuecomment-1096295130

   The fix is not to prevent from decoding twice. It is to prevent from decoding each time we call `KeyValueSchemaImpl:: atSchemaVersion` which happens for instance when you call `getReaderSchema`. In some sinks we call `getReaderchema` on each received message so it's done a lot of times.
   There could be optimizations to prevent from decoding twice by optimizing `SchemaInfoProvider` but it's not the purpose of this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org