You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Marco Massenzio <m....@gmail.com> on 2016/02/13 18:32:57 UTC

Re: Review Request 41854: Added module initialization to Master main().

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41854/
-----------------------------------------------------------

(Updated Feb. 13, 2016, 5:32 p.m.)


Review request for mesos, Anand Mazumdar and Kapil Arya.


Changes
-------

Added missing period to commit message.


Summary (updated)
-----------------

Added module initialization to Master main().


Bugs: MESOS-4253
    https://issues.apache.org/jira/browse/MESOS-4253


Repository: mesos


Description (updated)
-------

Added module initialization to Master main().


Diffs (updated)
-----

  src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
  src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 

Diff: https://reviews.apache.org/r/41854/diff/


Testing
-------

make && make check

[==========] 932 tests from 119 test cases ran. (210502 ms total)
[  PASSED  ] 932 tests.


Thanks,

Marco Massenzio


Re: Review Request 41854: Added module initialization to Master main().

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41854/#review119158
-----------------------------------------------------------



Patch looks great!

Reviews applied: [41760, 41854]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 13, 2016, 5:32 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41854/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Bugs: MESOS-4253
>     https://issues.apache.org/jira/browse/MESOS-4253
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added module initialization to Master main().
> 
> 
> Diffs
> -----
> 
>   src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
>   src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 
> 
> Diff: https://reviews.apache.org/r/41854/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> [==========] 932 tests from 119 test cases ran. (210502 ms total)
> [  PASSED  ] 932 tests.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>


Re: Review Request 41854: Added module initialization to Master main().

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41854/#review121071
-----------------------------------------------------------


Ship it!




Ship It!

- Kapil Arya


On Feb. 13, 2016, 12:32 p.m., Marco Massenzio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41854/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2016, 12:32 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Kapil Arya.
> 
> 
> Bugs: MESOS-4253
>     https://issues.apache.org/jira/browse/MESOS-4253
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added module initialization to Master main().
> 
> 
> Diffs
> -----
> 
>   src/master/main.cpp 4263110c9b889984ef74eb94fed629958f2abd79 
>   src/slave/main.cpp 222198ca89f672332cb80773a3f36fe1f0438f64 
> 
> Diff: https://reviews.apache.org/r/41854/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> [==========] 932 tests from 119 test cases ran. (210502 ms total)
> [  PASSED  ] 932 tests.
> 
> 
> Thanks,
> 
> Marco Massenzio
> 
>