[GitHub] [incubator-pegasus] Smityz commented on a change in pull request #604: feat(hotspot): calculator auto detect hotkey in the hot partition

[GitBox <gi...@apache.org>]

Smityz commented on a change in pull request #604:
URL: https://github.com/apache/incubator-pegasus/pull/604#discussion_r490716519



##########
File path: src/server/test/hotspot_partition_test.cpp
##########
@@ -58,6 +63,16 @@ class hotspot_partition_test : public pegasus_server_test_base
         std::vector<std::vector<double>> result = get_calculator_result(calculator._hot_points);
         ASSERT_EQ(result, expect_result);
     }
+    void aggregate_analyse_data(std::vector<row_data> scenario,

Review comment:
       In line 69
   ```cpp
   calculator.data_aggregate(std::move(scenario));
   ```
   It can't be a ref




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org