You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by zd-project <gi...@git.apache.org> on 2018/06/07 14:20:18 UTC

[GitHub] storm pull request #2708: STORM-3098: Fixed method filterChangingBlobsFor()

GitHub user zd-project opened a pull request:

    https://github.com/apache/storm/pull/2708

    STORM-3098: Fixed method filterChangingBlobsFor()

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zd-project/storm STORM-3098

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2708.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2708
    
----
commit 498da9e77cec4d5cb9dfbb1044cb9634f1ff0422
Author: Zhengdai Hu <hu...@...>
Date:   2018-06-07T14:19:44Z

    STORM-3098: Fixed method filterChangingBlobsFor()

----


---

[GitHub] storm issue #2708: STORM-3098: Fixed method filterChangingBlobsFor()

Posted by revans2 <gi...@git.apache.org>.

Github user revans2 commented on the issue:

    https://github.com/apache/storm/pull/2708
  
    Conceptually the change looks like a good fix.
    
    When I first wrote the code I would launch a topology which depended on several blobs, some that required a relaunch of the worker and others that didn't.  I then manually verified that the worker was relaunched when I changed the ones that required a relaunch and wasn't relaunched for ones that didn't need it.  It would be good to at least verify that it is still working after this change, and more importantly is this code needed at all if it was working before.


---

[GitHub] storm pull request #2708: STORM-3098: Fixed method filterChangingBlobsFor()

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2708


---

[GitHub] storm issue #2708: STORM-3098: Fixed method filterChangingBlobsFor()

Posted by zd-project <gi...@git.apache.org>.

Github user zd-project commented on the issue:

    https://github.com/apache/storm/pull/2708
  
    I extended the test to cover the testing of filterChangingBlob now.


---