You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/22 04:42:40 UTC

[GitHub] [superset] surajsunrays opened a new pull request, #22503: Updated Chart.yaml with the latest versions of postgresql and redis for superset

surajsunrays opened a new pull request, #22503:
URL: https://github.com/apache/superset/pull/22503

   ### Title
   fix(helm chart): Updated Chart.yaml with the latest versions of PostgreSQL and Redis for the superset
   
   ### SUMMARY
   Chart versions for PostgreSQL and Redis were outdated causing the `helm dependency build` to fail.
   
   Updated these charts versions for the latest ones, which supports the build and solves the issue.
   
   Before pushing this commit, changes have been tested on the local system, and also tried deploying the updated charts or local Kubernetes cluster (created using r3d) 
   
   
   ### TESTING INSTRUCTIONS
   Following the commands mentioned here to test out the changes
   https://superset.apache.org/docs/installation/installing-superset-from-scratch#installing-superset-with-helm-in-kubernetes
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] craig-rueda commented on pull request #22503: fix(helm): Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #22503:
URL: https://github.com/apache/superset/pull/22503#issuecomment-1371421529

   Closing in favor of https://github.com/apache/superset/pull/22590
   
   Bumps linters and updates inline docs ☝️ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] surajsunrays commented on pull request #22503: fix(helm): Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
surajsunrays commented on PR #22503:
URL: https://github.com/apache/superset/pull/22503#issuecomment-1369141509

   > Pls take a look at the failed checks. Looks like the issue isn't the readme, but rather helm docs
   
   @craig-rueda could you please help me to resolve the failed checks? I cannot understand why it is failing and which file(s) need to be updated to fix it. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] craig-rueda closed pull request #22503: fix(helm): Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
craig-rueda closed pull request #22503: fix(helm): Updated Chart.yaml with the latest versions of postgresql and redis for superset
URL: https://github.com/apache/superset/pull/22503


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] craig-rueda commented on pull request #22503: fix: Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #22503:
URL: https://github.com/apache/superset/pull/22503#issuecomment-1366195564

   Soon? 🤣


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] surajsunrays commented on pull request #22503: Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
surajsunrays commented on PR #22503:
URL: https://github.com/apache/superset/pull/22503#issuecomment-1364894142

   @craig-rueda When are you planning to merge this pull request?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] surajsunrays commented on pull request #22503: fix(helm): Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
surajsunrays commented on PR #22503:
URL: https://github.com/apache/superset/pull/22503#issuecomment-1368880981

   > Looks like some checks are still failing.
   
   Updated README.md with required documentation details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] surajsunrays commented on a diff in pull request #22503: Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
surajsunrays commented on code in PR #22503:
URL: https://github.com/apache/superset/pull/22503#discussion_r1056290937


##########
helm/superset/Chart.yaml:
##########
@@ -32,10 +32,10 @@ maintainers:
 version: 0.7.7

Review Comment:
   Addressed: Updated chart version from 0.7.7 to 0.7.8



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] craig-rueda commented on a diff in pull request #22503: Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on code in PR #22503:
URL: https://github.com/apache/superset/pull/22503#discussion_r1055801463


##########
helm/superset/Chart.yaml:
##########
@@ -32,10 +32,10 @@ maintainers:
 version: 0.7.7

Review Comment:
   Need to update the chart version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] craig-rueda commented on pull request #22503: fix(helm): Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #22503:
URL: https://github.com/apache/superset/pull/22503#issuecomment-1367581566

   Looks like some checks are still failing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] craig-rueda commented on pull request #22503: fix(helm): Updated Chart.yaml with the latest versions of postgresql and redis for superset

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on PR #22503:
URL: https://github.com/apache/superset/pull/22503#issuecomment-1369111066

   Pls take a look at the failed checks. Looks like the issue isn't the readme, but rather helm docs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org