You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Jarek Cecho <ja...@apache.org> on 2011/12/10 19:50:28 UTC
Review Request: FLUME-881: Would be nice if HDFS Sink would automatically
choose best writableFormat based on fileType
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3146/
-----------------------------------------------------------
Review request for Flume and Eric Sammer.
Summary
-------
I've put "dynamic default value" as is described in the JIRA. Please note that this patch is not working properly without patch from FLUME-880.
This addresses bug FLUME-881.
https://issues.apache.org/jira/browse/FLUME-881
Diffs
-----
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1212827
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSFormatterFactory.java 1212827
Diff: https://reviews.apache.org/r/3146/diff
Testing
-------
I've tested it on my test cluster, no formal tests were included.
Thanks,
Jarek
Re: Review Request: FLUME-881: Would be nice if HDFS Sink would
automatically choose best writableFormat based on fileType
Posted by Jarek Cecho <ja...@apache.org>.
> On 2012-03-22 16:37:01, Arvind Prabhakar wrote:
> > Thanks for the patch Jarcec. For some reason I am running into test failures when applying this patch. Can you please have a look?
Thank you very much for your time Arvind, I'll do that over the weekend.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3146/#review6225
-----------------------------------------------------------
On 2012-03-21 06:46:22, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3146/
> -----------------------------------------------------------
>
> (Updated 2012-03-21 06:46:22)
>
>
> Review request for Flume, Arvind Prabhakar and Eric Sammer.
>
>
> Summary
> -------
>
> I've put "dynamic default value" as is described in the JIRA. Please note that this patch is not working properly without patch from FLUME-880.
>
>
> This addresses bug FLUME-881.
> https://issues.apache.org/jira/browse/FLUME-881
>
>
> Diffs
> -----
>
> /branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1212827
>
> Diff: https://reviews.apache.org/r/3146/diff
>
>
> Testing
> -------
>
> I've tested it on my test cluster, no formal tests were included.
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: FLUME-881: Would be nice if HDFS Sink would
automatically choose best writableFormat based on fileType
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3146/#review6225
-----------------------------------------------------------
Thanks for the patch Jarcec. For some reason I am running into test failures when applying this patch. Can you please have a look?
- Arvind
On 2012-03-21 06:46:22, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3146/
> -----------------------------------------------------------
>
> (Updated 2012-03-21 06:46:22)
>
>
> Review request for Flume, Arvind Prabhakar and Eric Sammer.
>
>
> Summary
> -------
>
> I've put "dynamic default value" as is described in the JIRA. Please note that this patch is not working properly without patch from FLUME-880.
>
>
> This addresses bug FLUME-881.
> https://issues.apache.org/jira/browse/FLUME-881
>
>
> Diffs
> -----
>
> /branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1212827
>
> Diff: https://reviews.apache.org/r/3146/diff
>
>
> Testing
> -------
>
> I've tested it on my test cluster, no formal tests were included.
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: FLUME-881: Would be nice if HDFS Sink would
automatically choose best writableFormat based on fileType
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3146/#review6343
-----------------------------------------------------------
Ship it!
+1
- Arvind
On 2012-03-25 16:59:47, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3146/
> -----------------------------------------------------------
>
> (Updated 2012-03-25 16:59:47)
>
>
> Review request for Flume, Arvind Prabhakar and Eric Sammer.
>
>
> Summary
> -------
>
> I've put "dynamic default value" as is described in the JIRA. Please note that this patch is not working properly without patch from FLUME-880.
>
>
> This addresses bug FLUME-881.
> https://issues.apache.org/jira/browse/FLUME-881
>
>
> Diffs
> -----
>
> /trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1305074
>
> Diff: https://reviews.apache.org/r/3146/diff
>
>
> Testing
> -------
>
> I've tested it on my test cluster, no formal tests were included.
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: FLUME-881: Would be nice if HDFS Sink would
automatically choose best writableFormat based on fileType
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3146/
-----------------------------------------------------------
(Updated 2012-03-25 16:59:47.892388)
Review request for Flume, Arvind Prabhakar and Eric Sammer.
Changes
-------
Hi Arvind, I've rebased patch based on current trunk and run tests. It seems to be working.
Summary
-------
I've put "dynamic default value" as is described in the JIRA. Please note that this patch is not working properly without patch from FLUME-880.
This addresses bug FLUME-881.
https://issues.apache.org/jira/browse/FLUME-881
Diffs (updated)
-----
/trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1305074
Diff: https://reviews.apache.org/r/3146/diff
Testing
-------
I've tested it on my test cluster, no formal tests were included.
Thanks,
Jarek
Re: Review Request: FLUME-881: Would be nice if HDFS Sink would
automatically choose best writableFormat based on fileType
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3146/
-----------------------------------------------------------
(Updated 2012-03-21 06:46:22.154059)
Review request for Flume, Arvind Prabhakar and Eric Sammer.
Summary
-------
I've put "dynamic default value" as is described in the JIRA. Please note that this patch is not working properly without patch from FLUME-880.
This addresses bug FLUME-881.
https://issues.apache.org/jira/browse/FLUME-881
Diffs
-----
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1212827
Diff: https://reviews.apache.org/r/3146/diff
Testing
-------
I've tested it on my test cluster, no formal tests were included.
Thanks,
Jarek
Re: Review Request: FLUME-881: Would be nice if HDFS Sink would
automatically choose best writableFormat based on fileType
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3146/
-----------------------------------------------------------
(Updated 2011-12-10 18:52:04.153938)
Review request for Flume and Eric Sammer.
Changes
-------
Updated version that is removing (sub)patch that is solving FLUME-880.
Summary
-------
I've put "dynamic default value" as is described in the JIRA. Please note that this patch is not working properly without patch from FLUME-880.
This addresses bug FLUME-881.
https://issues.apache.org/jira/browse/FLUME-881
Diffs (updated)
-----
/branches/flume-728/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java 1212827
Diff: https://reviews.apache.org/r/3146/diff
Testing
-------
I've tested it on my test cluster, no formal tests were included.
Thanks,
Jarek