[GitHub] [helix] junkaixue commented on a change in pull request #1848: Add stop server wait time to be 10 seconds in MockMetadataStoreDirectoryServer to avoid test failure.

[GitBox <gi...@apache.org>]

junkaixue commented on a change in pull request #1848:
URL: https://github.com/apache/helix/pull/1848#discussion_r694357046



##########
File path: metadata-store-directory-common/src/main/java/org/apache/helix/msdcommon/mock/MockMetadataStoreDirectoryServer.java
##########
@@ -103,7 +104,7 @@ public void startServer() throws IOException {
   }
 
   public void stopServer() {
-    _server.stop(0);
+    _server.stop(STOP_WAIT_SEC);

Review comment:
       Is this timeout meaning wait 10 seconds and try stop or totally timeout is 10 second can be terminated anytime during the middle as long as it is free?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org