You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@whimsical.apache.org by sebb <se...@gmail.com> on 2017/06/13 09:53:50 UTC

Fix alignment in generated conf file

I know it's trivial, but it looks odd to have mis-alignment like:

<Location /roster>
PassengerBaseURI /roster
  PassengerAppRoot /srv/whimsy/www/roster
  Options -MultiViews
  CheckSpelling Off
  # SetEnv HTTPS on
</Location>

I think there's a trivial fix:

Change
        content.strip!.gsub! /^#{content[/^\s+/]}/, ' '
to
        content.strip!.gsub! /^\s*/, '  '
at

https://github.com/apache/infrastructure-puppet/blob/deployment/modules/vhosts_whimsy/lib/puppet/parser/functions/preprocess_vhosts.rb#L46

OK?

Re: Fix alignment in generated conf file

Posted by Sam Ruby <ru...@intertwingly.net>.

On Tue, Jun 13, 2017 at 5:53 AM, sebb <se...@gmail.com> wrote:
> I know it's trivial, but it looks odd to have mis-alignment like:
>
> <Location /roster>
> PassengerBaseURI /roster
>   PassengerAppRoot /srv/whimsy/www/roster
>   Options -MultiViews
>   CheckSpelling Off
>   # SetEnv HTTPS on
> </Location>
>
> I think there's a trivial fix:
>
> Change
>         content.strip!.gsub! /^#{content[/^\s+/]}/, ' '
> to
>         content.strip!.gsub! /^\s*/, '  '
> at
>
> https://github.com/apache/infrastructure-puppet/blob/deployment/modules/vhosts_whimsy/lib/puppet/parser/functions/preprocess_vhosts.rb#L46
>
> OK?

If you see something that could be improved, just go for it.

- Sam Ruby