[GitHub] [lucene-solr] gerlowskija commented on a change in pull request #665: Fixes SOLR-13539

[GitBox <gi...@apache.org>]

gerlowskija commented on a change in pull request #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#discussion_r320246350
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/handler/loader/XMLLoader.java
 ##########
 @@ -429,7 +434,18 @@ public SolrInputDocument readDoc(XMLStreamReader parser) throws XMLStreamExcepti
             break;
           } else if ("field".equals(parser.getLocalName())) {
             // should I warn in some text has been found too
-            Object v = isNull ? null : text.toString();
+            Object v;
 
 Review comment:
   So, just to make sure I understand: what is "binary XML" here?  Is this XML where some node in the XML doc has binary content?  Is this normal XML where the whole XML doc/string has been encoded using some binary format for compression or quicker transmission?
   
   > this was the reason binary XML support was not working at least since 6.6.2
   Interesting.  Is this something that Solr claimed to support or had support for at some point?  Or this is a new ability that Solr has never had that you're adding here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org