You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/05/10 08:51:26 UTC

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #5006: Disk controller vmware deploy as is

Spaceman1984 opened a new pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006


   ### Description
   
   This PR...
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   Fixes: #4344
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   This has been tested by stopping an instance and changing the disk controller setting.
   Note - when using a deploy as is template these settings are greyed out.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 closed pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842336268


   @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836524063


   @blueorangutan help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841309254


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 24


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841135336


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 22


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841294391


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r630770703



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2067,9 +2067,7 @@ protected StartAnswer execute(StartCommand cmd) {
                 }
 
                 VirtualMachineDiskInfo matchingExistingDisk = getMatchingExistingDisk(diskInfoBuilder, vol, hyperHost, context);
-                controllerKey = getDiskController(matchingExistingDisk, vol, vmSpec, ideControllerKey, scsiControllerKey);

Review comment:
       Unused code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r633235333



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2521,6 +2521,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUnavailableEx
         String extraConfig = cmd.getExtraConfig();
 
         UserVmVO vmInstance = _vmDao.findById(cmd.getId());
+        if (MapUtils.isNotEmpty(details)) {

Review comment:
       @Spaceman1984 should we also check cleanupDetails param here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836746451


   > code looks good, but I cannot judge the view redefinition. extensive testing needed for that
   
   I added this line to the view definition @DaanHoogland 
   
   ``vm_template`.`deploy_as_is` AS `template_deploy_as_is`,`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r629249996



##########
File path: api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
##########
@@ -124,6 +124,10 @@
     @Param(description = " an alternate display text of the template for the virtual machine")
     private String templateDisplayText;
 
+    @SerializedName("deployasistemplate")

Review comment:
       You want to move this to `ApiConstants....`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-840193893


   <b>Trillian test result (tid-672)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 59528 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5006-t672-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_iso.py
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
   Smoke tests completed. 84 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3611.43 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 92.36 | test_kubernetes_clusters.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 87.51 | test_routers_network_ops.py
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 634.11 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 520.18 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 556.57 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r630118487



##########
File path: ui/src/components/view/DetailSettings.vue
##########
@@ -96,6 +97,7 @@
             :title="`${$t('label.delete.setting')}?`"
             @confirm="deleteDetail(index)"
             :okText="$t('label.yes')"
+            :disabled="deployasistemplate === true && (item.name === 'rootDiskController' || item.name === 'dataDiskController')"

Review comment:
       Same as above

##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2067,9 +2067,7 @@ protected StartAnswer execute(StartCommand cmd) {
                 }
 
                 VirtualMachineDiskInfo matchingExistingDisk = getMatchingExistingDisk(diskInfoBuilder, vol, hyperHost, context);
-                controllerKey = getDiskController(matchingExistingDisk, vol, vmSpec, ideControllerKey, scsiControllerKey);

Review comment:
       Why is this being removed? 

##########
File path: ui/src/components/view/DetailSettings.vue
##########
@@ -85,6 +85,7 @@
           <tooltip-button
             :tooltip="$t('label.edit')"
             icon="edit"
+            :disabled="deployasistemplate === true && (item.name === 'rootDiskController' || item.name === 'dataDiskController')"

Review comment:
       I think `deployasistemplate === true` should be enough in this condition

##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -3273,47 +3271,9 @@ private VirtualMachineDiskInfo getMatchingExistingDisk(VirtualMachineDiskInfoBui
         return null;
     }
 
-    private int getDiskController(VirtualMachineDiskInfo matchingExistingDisk, DiskTO vol, VirtualMachineTO vmSpec, int ideControllerKey, int scsiControllerKey) {

Review comment:
       Same ^^




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-843804538


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd merged pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842749531


   <b>Trillian test result (tid-702)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 40415 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5006-t702-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
   Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
   Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
   Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
   Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
   Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
   Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
   Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_templates.py
   Intermittent failure detected: /marvin/tests/smoke/test_usage.py
   Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
   Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 66 look OK, 21 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 459.75 | test_internal_lb.py
   test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 484.39 | test_internal_lb.py
   ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
   ContextSuite context=TestRAMCPUResourceAccounting>:setup | `Error` | 0.00 | test_resource_accounting.py
   ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
   ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
   ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
   ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
   test_01_isolate_network_FW_PF_default_routes_egress_true | `Error` | 0.15 | test_routers_network_ops.py
   test_02_isolate_network_FW_PF_default_routes_egress_false | `Error` | 0.17 | test_routers_network_ops.py
   ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 1.28 | test_routers_network_ops.py
   ContextSuite context=TestRouterServices>:setup | `Error` | 0.00 | test_routers.py
   test_01_sys_vm_start | `Failure` | 60.15 | test_secondary_storage.py
   ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.10 | test_service_offerings.py
   ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
   test_01_list_sec_storage_vm | `Failure` | 0.03 | test_ssvm.py
   test_03_ssvm_internals | `Failure` | 0.03 | test_ssvm.py
   test_05_stop_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_07_reboot_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_09_destroy_ssvm | `Failure` | 0.03 | test_ssvm.py
   test_01_import_storage_policies | `Error` | 0.00 | test_storage_policy.py
   test_01_create_template | `Error` | 51.12 | test_templates.py
   test_CreateTemplateWithDuplicateName | `Error` | 93.18 | test_templates.py
   test_02_create_template_with_checksum_sha1 | `Error` | 65.38 | test_templates.py
   test_03_create_template_with_checksum_sha256 | `Error` | 65.39 | test_templates.py
   test_04_create_template_with_checksum_md5 | `Error` | 65.38 | test_templates.py
   test_05_create_template_with_no_checksum | `Error` | 65.39 | test_templates.py
   test_03_delete_template | `Error` | 1.06 | test_templates.py
   test_04_extract_template | `Error` | 1.06 | test_templates.py
   test_09_list_templates_download_details | `Failure` | 0.07 | test_templates.py
   ContextSuite context=TestISOUsage>:setup | `Error` | 0.00 | test_usage.py
   test_01_template_usage | `Error` | 1.12 | test_usage.py
   test_01_volume_usage | `Error` | 71.89 | test_usage.py
   ContextSuite context=TestVAppsVM>:setup | `Error` | 45.22 | test_vm_life_cycle.py
   test_10_attachAndDetach_iso | `Failure` | 1510.39 | test_vm_life_cycle.py
   test_06_download_detached_volume | `Error` | 201.69 | test_volumes.py
   ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
   ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
   ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r630771165



##########
File path: ui/src/components/view/DetailSettings.vue
##########
@@ -96,6 +97,7 @@
             :title="`${$t('label.delete.setting')}?`"
             @confirm="deleteDetail(index)"
             :okText="$t('label.yes')"
+            :disabled="deployasistemplate === true && (item.name === 'rootDiskController' || item.name === 'dataDiskController')"

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841277698


   Packaging result: :heavy_multiplication_x: centos7 :heavy_multiplication_x: centos8 :heavy_multiplication_x: debian. SL-JID 23


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] nvazquez commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r632487954



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2521,6 +2521,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUnavailableEx
         String extraConfig = cmd.getExtraConfig();
 
         UserVmVO vmInstance = _vmDao.findById(cmd.getId());
+        if (details.size() > 0) {

Review comment:
       Maybe `MapUtils.isNotEmpty(details)` to prevent possible NPE?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r631687191



##########
File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
##########
@@ -830,6 +830,7 @@
     public static final String BOOT_MODE = "bootmode";
     public static final String BOOT_INTO_SETUP = "bootintosetup";
     public static final String DEPLOY_AS_IS = "deployasis";
+    public static final String DEPLOY_AS_IS_TEMPLATE = "deployasistemplate";

Review comment:
       @Spaceman1984 is this still used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836527454


   @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842082969


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836523317


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 551


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r630770961



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -3273,47 +3271,9 @@ private VirtualMachineDiskInfo getMatchingExistingDisk(VirtualMachineDiskInfoBui
         return null;
     }
 
-    private int getDiskController(VirtualMachineDiskInfo matchingExistingDisk, DiskTO vol, VirtualMachineTO vmSpec, int ideControllerKey, int scsiControllerKey) {

Review comment:
       Unused code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r629272727



##########
File path: api/src/main/java/org/apache/cloudstack/api/response/UserVmResponse.java
##########
@@ -124,6 +124,10 @@
     @Param(description = " an alternate display text of the template for the virtual machine")
     private String templateDisplayText;
 
+    @SerializedName("deployasistemplate")

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r632401237



##########
File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
##########
@@ -830,6 +830,7 @@
     public static final String BOOT_MODE = "bootmode";
     public static final String BOOT_INTO_SETUP = "bootintosetup";
     public static final String DEPLOY_AS_IS = "deployasis";
+    public static final String DEPLOY_AS_IS_TEMPLATE = "deployasistemplate";

Review comment:
       No




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842341764


   Let's merge this after a smoketest run kicked above ^^ and if @vladimirpetrov agrees, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842335559






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836402154


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842140030


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841273124


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-843517683


   <b>Trillian test result (tid-704)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 46542 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5006-t704-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
   Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
   Smoke tests completed. 86 look OK, 1 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 529.18 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Failure` | 512.85 | test_vpc_redundant.py
   test_05_rvpc_multi_tiers | `Error` | 549.99 | test_vpc_redundant.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] shwstppr commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r633235333



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2521,6 +2521,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUnavailableEx
         String extraConfig = cmd.getExtraConfig();
 
         UserVmVO vmInstance = _vmDao.findById(cmd.getId());
+        if (MapUtils.isNotEmpty(details)) {

Review comment:
       @Spaceman1984 should we also check cleanupDetails param here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842140645


   @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-843829787


   @vladimirpetrov are you lgtm on it? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841131835


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-839543161


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-839513422


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 edited a comment on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 edited a comment on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836746451


   > code looks good, but I cannot judge the view redefinition. extensive testing needed for that
   
   I added this line to the view definition @DaanHoogland 
   
   ```
   `vm_template`.`deploy_as_is` AS `template_deploy_as_is`,
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-837625181


   <b>Trillian test result (tid-636)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 53979 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5006-t636-vmware-67u3.zip
   Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
   Intermittent failure detected: /marvin/tests/smoke/test_routers.py
   Intermittent failure detected: /marvin/tests/smoke/test_storage_policy.py
   Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
   Smoke tests completed. 84 look OK, 3 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3605.50 | test_kubernetes_clusters.py
   test_02_deploy_and_upgrade_kubernetes_cluster | `Failure` | 3610.90 | test_kubernetes_clusters.py
   test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_04_basic_lifecycle_kubernetes_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_05_delete_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
   test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
   ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 122.75 | test_kubernetes_clusters.py
   test_01_import_storage_policies | `Error` | 12.16 | test_storage_policy.py
   ContextSuite context=TestVMWareStoragePolicies>:teardown | `Error` | 13.24 | test_storage_policy.py
   test_01_redundant_vpc_site2site_vpn | `Failure` | 454.78 | test_vpc_vpn.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r630771068



##########
File path: ui/src/components/view/DetailSettings.vue
##########
@@ -85,6 +85,7 @@
           <tooltip-button
             :tooltip="$t('label.edit')"
             icon="edit"
+            :disabled="deployasistemplate === true && (item.name === 'rootDiskController' || item.name === 'dataDiskController')"

Review comment:
       Done




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842083339


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-840425523


   Ping @sureshanaparti, @harikrishna-patnala / @nvazquez can you help review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841318709


   @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r633286358



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2521,6 +2521,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUnavailableEx
         String extraConfig = cmd.getExtraConfig();
 
         UserVmVO vmInstance = _vmDao.findById(cmd.getId());
+        if (MapUtils.isNotEmpty(details)) {

Review comment:
       Yes, that would be good.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842083339






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841585969


   <b>Trillian test result (tid-685)</b>
   Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37976 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5006-t685-vmware-67u3.zip
   Smoke tests completed. 87 look OK, 0 have error(s)
   Only failed tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-839538802


   Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 587


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841318352


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-839712436


   @nvazquez can you review this PR? thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836524718


   @Spaceman1984 I understand these words: "help", "hello", "thanks", "package", "test"
   Test command usage: test [mgmt os] [hypervisor] [keepEnv]
   Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
   Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-70u1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
   	Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the `matrix` command.
   
   Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti', 'weizhouapache']


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842899795


   @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836403224


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 removed a comment on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 removed a comment on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-843804538


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841126994


   Changes made @shwstppr 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842146126


   <b>Trillian Build Failed (tid-698)<b/>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836830169


   @nvazquez please review this thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 closed pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 closed pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r632559711



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2521,6 +2521,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUnavailableEx
         String extraConfig = cmd.getExtraConfig();
 
         UserVmVO vmInstance = _vmDao.findById(cmd.getId());
+        if (details.size() > 0) {

Review comment:
       Sure




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836526342


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r633286358



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2521,6 +2521,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) throws ResourceUnavailableEx
         String extraConfig = cmd.getExtraConfig();
 
         UserVmVO vmInstance = _vmDao.findById(cmd.getId());
+        if (MapUtils.isNotEmpty(details)) {

Review comment:
       Yes, that would be good.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842082969






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-836743556


   since the user_vm_view changed, do we really want this in 4.15?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842156094


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841272886


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-839513695


   @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-839543592


   @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842899503


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rhtyd commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842335559


   @blueorangutan test centos7 vmware-67u3


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-842109724


   Packaging result: :heavy_check_mark: centos7 :heavy_multiplication_x: centos8 :heavy_check_mark: debian. SL-JID 41


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841131478


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] Spaceman1984 commented on pull request #5006: Disk controller vmware deploy as is

Posted by GitBox <gi...@apache.org>.
Spaceman1984 commented on pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#issuecomment-841293773


   @blueorangutan package


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org