You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/04/26 14:12:46 UTC
Review Request 58739: test_kill_process_with_children and
test_facterMemInfoOutput test fails
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58739/
-----------------------------------------------------------
Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
Bugs: AMBARI-20776
https://issues.apache.org/jira/browse/AMBARI-20776
Repository: ambari
Description
-------
======================================================================
FAIL: test_kill_process_with_children (TestShell.TestShell)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/xxx/SOURCES/ambari/ambari-agent/src/test/python/ambari_agent/TestShell.py", line 71, in test_kill_process_with_children
self.assertTrue(sleep_cmd in out)
AssertionError
======================================================================
FAIL: test_facterMemInfoOutput (TestHardware.TestHardware)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/xxx/SOURCES/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
return func(*args, **keywargs)
File "/xxx/SOURCES/ambari/ambari-agent/src/test/python/ambari_agent/TestHardware.py", line 247, in test_facterMemInfoOutput
self.assertEquals(result['memorysize'], 1832392)
AssertionError: u'4194304' != 1832392
Diffs
-----
ambari-agent/src/test/python/ambari_agent/TestHardware.py d30020c
ambari-agent/src/test/python/ambari_agent/TestShell.py 5dc1899
Diff: https://reviews.apache.org/r/58739/diff/1/
Testing
-------
Unit tests passed.
Thanks,
Dmytro Sen
Re: Review Request 58739: test_kill_process_with_children and
test_facterMemInfoOutput test fails
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58739/#review173048
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On April 26, 2017, 2:12 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58739/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 2:12 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sid Wagle, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20776
> https://issues.apache.org/jira/browse/AMBARI-20776
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ======================================================================
> FAIL: test_kill_process_with_children (TestShell.TestShell)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/xxx/SOURCES/ambari/ambari-agent/src/test/python/ambari_agent/TestShell.py", line 71, in test_kill_process_with_children
> self.assertTrue(sleep_cmd in out)
> AssertionError
>
> ======================================================================
> FAIL: test_facterMemInfoOutput (TestHardware.TestHardware)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/xxx/SOURCES/ambari/ambari-common/src/test/python/mock/mock.py", line 1199, in patched
> return func(*args, **keywargs)
> File "/xxx/SOURCES/ambari/ambari-agent/src/test/python/ambari_agent/TestHardware.py", line 247, in test_facterMemInfoOutput
> self.assertEquals(result['memorysize'], 1832392)
> AssertionError: u'4194304' != 1832392
>
>
> Diffs
> -----
>
> ambari-agent/src/test/python/ambari_agent/TestHardware.py d30020c
> ambari-agent/src/test/python/ambari_agent/TestShell.py 5dc1899
>
>
> Diff: https://reviews.apache.org/r/58739/diff/1/
>
>
> Testing
> -------
>
> Unit tests passed.
>
>
> Thanks,
>
> Dmytro Sen
>
>