You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/06/15 16:25:18 UTC

[GitHub] [accumulo] keith-turner commented on a change in pull request #1487: Fixes: #1323 Implement a write thread limit

keith-turner commented on a change in pull request #1487:
URL: https://github.com/apache/accumulo/pull/1487#discussion_r440275644



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -381,6 +381,9 @@
   TSERV_MEM_MGMT("tserver.memory.manager",
       "org.apache.accumulo.server.tabletserver.LargestFirstMemoryManager", PropertyType.CLASSNAME,
       "An implementation of MemoryManger that accumulo will use."),
+  TSERV_MAX_WRITETHREADS("tserver.max.writethreads", "0", PropertyType.COUNT,

Review comment:
       I would suggest changing the property name to something like the following.  Going from general to specific in the property name allows like properties to sort together.
   
   ```suggestion
     TSERV_MAX_WRITETHREADS("tserver.write.threads.max", "0", PropertyType.COUNT,
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org