You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by ne...@apache.org on 2017/04/03 15:25:00 UTC

mesos git commit: Removed an old comment from 'v1/mesos.proto'.

Repository: mesos
Updated Branches:
  refs/heads/master 30344e131 -> e37442578


Removed an old comment from 'v1/mesos.proto'.

This patch removes an old comment in 'include/v1/mesos.proto'
regarding the `DiskInfo.persistence.principal` field. Commit
73790d3c141f91cc3a8f546091ac62594995b788 removed this comment
from 'include/mesos.proto', but neglected to update the v1
proto definitions.

Review: https://reviews.apache.org/r/58150/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e3744257
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e3744257
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e3744257

Branch: refs/heads/master
Commit: e37442578597725d8b36660070e5a8d620faba8c
Parents: 30344e1
Author: Greg Mann <gr...@mesosphere.io>
Authored: Mon Apr 3 08:24:54 2017 -0700
Committer: Neil Conway <ne...@gmail.com>
Committed: Mon Apr 3 08:24:54 2017 -0700

----------------------------------------------------------------------
 include/mesos/v1/mesos.proto | 5 -----
 1 file changed, 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/e3744257/include/mesos/v1/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto
index 82d020e..2286231 100644
--- a/include/mesos/v1/mesos.proto
+++ b/include/mesos/v1/mesos.proto
@@ -964,11 +964,6 @@ message Resource {
       // with the "destroy" ACL to determine whether an entity
       // attempting to destroy the volume is permitted to do so.
       //
-      // NOTE: This field is optional, while the `principal` found in
-      // `ReservationInfo` is required. This field is optional to
-      // allow for the possibility of volume creation without a
-      // principal, though currently it must be provided.
-      //
       // NOTE: This field should match the FrameworkInfo.principal of
       // the framework that created the volume.
       optional string principal = 2;