[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #33357: Fix DagFileProcessor interfering with dags outside its ``processor_subdir``

["pierrejeambrun (via GitHub)" <gi...@apache.org>]

pierrejeambrun commented on code in PR #33357:
URL: https://github.com/apache/airflow/pull/33357#discussion_r1293809443


##########
airflow/models/dag.py:
##########
@@ -3555,16 +3555,26 @@ def set_is_paused(self, is_paused: bool, including_subdags: bool = True, session
     def deactivate_deleted_dags(
         cls,
         alive_dag_filelocs: Container[str],
+        processor_subdir: str | None = None,

Review Comment:
   Good idea. I double checked but indeed this is almost never used, only here and in 1 test that I adjusted.
   
   We can even narrow the type to just `str` as `get_dag_directory` guarantee a str value as input.
   
   Done :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org