You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/06/25 19:08:37 UTC

[GitHub] [calcite] julianhyde commented on pull request #2440: RelOptRulesTest improvements

julianhyde commented on pull request #2440:
URL: https://github.com/apache/calcite/pull/2440#issuecomment-868775932


   Conventionally when defining a lambda for `relFn` we call the `RelBuilder` `b`, not `relBuilder`. It makes the code more concise when we use the `RelBuilder` multiple times to create expressions. Can you stick to that convention.
   
   I think the `relFn` parameter and field need a `@Nullable` annotation.
   
   Why are there so many renames of "planBefore" to "planAfter" and vice versa? I can't tell whether these are real changes or just instability in the file format. If you can, preserve the file format. Generally "planBefore" should occur before "planAfter" (even though that is not alphabetical).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org