You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "jeantil (via GitHub)" <gi...@apache.org> on 2024/02/07 10:47:48 UTC
[PR] [JAMES-3978] activate flaky tests detection [james-project]
jeantil opened a new pull request, #1987:
URL: https://github.com/apache/james-project/pull/1987
Flaky test detection in develocity requires allowing test retry at least once. While this will probably make our test suite even longer than it already is, it could help prioritize the tests to be fixed to enabled test result remote caching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [JAMES-3978] activate flaky tests detection [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #1987:
URL: https://github.com/apache/james-project/pull/1987#discussion_r1483029974
##########
pom.xml:
##########
@@ -664,6 +664,8 @@
<mockito.version>5.2.0</mockito.version>
<jacoco-maven-plugin.version>0.8.9</jacoco-maven-plugin.version>
<javacrumbs.json-unit.version>2.38.0</javacrumbs.json-unit.version>
+
+ <surefire.rerunFailingTestsCount>2</surefire.rerunFailingTestsCount>
Review Comment:
Having this as a general property, I would not be sure this is the way.
Shouldn't we rather pass it as a property of the surefire maven plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [JAMES-3978] activate flaky tests detection [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1987:
URL: https://github.com/apache/james-project/pull/1987#issuecomment-1931779714
> Flaky test detection in develocity requires allowing test retry at least once.
It will not catch "the docker did not start" kind of flackyness though, unless the retry is done in a new JVM...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [JAMES-3978] activate flaky tests detection [james-project]
Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil commented on code in PR #1987:
URL: https://github.com/apache/james-project/pull/1987#discussion_r1483197818
##########
pom.xml:
##########
@@ -664,6 +664,8 @@
<mockito.version>5.2.0</mockito.version>
<jacoco-maven-plugin.version>0.8.9</jacoco-maven-plugin.version>
<javacrumbs.json-unit.version>2.38.0</javacrumbs.json-unit.version>
+
+ <surefire.rerunFailingTestsCount>2</surefire.rerunFailingTestsCount>
Review Comment:
actually your comment made me pause: do we want this behavior locally or only on CI ? in the latter case I would change the Jenkins file to pass the property to the command line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [JAMES-3978] activate flaky tests detection [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on PR #1987:
URL: https://github.com/apache/james-project/pull/1987#issuecomment-1934193933
404 on https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html
Let's merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [JAMES-3978] activate flaky tests detection [james-project]
Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil commented on PR #1987:
URL: https://github.com/apache/james-project/pull/1987#issuecomment-1934407829
wierd https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html works fine for me ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [JAMES-3978] activate flaky tests detection [james-project]
Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil commented on PR #1987:
URL: https://github.com/apache/james-project/pull/1987#issuecomment-1931794018
> It will not catch "the docker did not start" kind of flackyness though, unless the retry is done in a new JVM...
I would need to look at the surefire options : maybe there is a way to ensure that a retry occurs in a fresh fork ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [JAMES-3978] activate flaky tests detection [james-project]
Posted by "jeantil (via GitHub)" <gi...@apache.org>.
jeantil merged PR #1987:
URL: https://github.com/apache/james-project/pull/1987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org