Re: Review Request 72902: ATLAS-3875: Introduce python client for Atlas (updated patch from https://reviews.apache.org/r/72730/)

[Madhan Neethiraj <ma...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72902/#review221999
-----------------------------------------------------------


Fix it, then Ship it!




Looks good Sarath!


intg/src/main/python/README.md
Lines 8 (patched)
<https://reviews.apache.org/r/72902/#comment311065>

    'python setup.py install' - this seems to be performed by Atlas team, and not the end user of the library. Please review and update.



intg/src/main/python/apache_atlas/base_client.py
Lines 81 (patched)
<https://reviews.apache.org/r/72902/#comment311067>

    'response' doesn't have to an attribute of AtlasClient instance. Since this is used only within call_api() method, consider using a local variable instead i.e. get rid of 'self.' prefix.


- Madhan Neethiraj


On Sept. 23, 2020, 6:58 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72902/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2020, 6:58 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-3875
>     https://issues.apache.org/jira/browse/ATLAS-3875
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> This is a updated patch from https://reviews.apache.org/r/72730/
> 
> Few additional changes:
> 1. Formatting changes
> 2. Renamed atlas_client to apache_atlas
> 3. Moved client and model files into intg module
> 4. Updated README files.
> 
> ---------------------------------
> Added basic structure for Python client
> This includes all classes for Entity and TypeDef
> Added all endpoints for typedef, Entity, Glossary, Lineage and Relationship
> Added Python Sample project to test basic APIs and as a guideline
> Added logging and readme file
> 
> 
> Diffs
> -----
> 
>   .gitignore 90ca27646 
>   atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java e4fc4edbf 
>   atlas-examples/sample-app/src/main/python/README.md PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/request_json/typedef_create.json PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION 
>   atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION 
>   intg/src/main/python/LICENSE PRE-CREATION 
>   intg/src/main/python/README.md PRE-CREATION 
>   intg/src/main/python/apache_atlas/__init__.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/base_client.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/client/__init__.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/client/discovery.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/client/entity.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/client/glossary.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/client/lineage.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/client/relationship.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/client/typedef.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/exceptions.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/__init__.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/discovery.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/entity.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/glossary.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/lineage.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/relationship.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/typedef.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/utils.py PRE-CREATION 
>   intg/src/main/python/requirements.txt PRE-CREATION 
>   intg/src/main/python/setup.py PRE-CREATION 
>   intg/src/main/python/tests/__init__.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72902/diff/1/
> 
> 
> Testing
> -------
> 
> Local testing done
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>