You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by TomohitoNakayama <to...@basil.ocn.ne.jp> on 2005/05/19 15:15:59 UTC

Patch for DERBY-167 again*3

Hello.

I have made new patch.

What was changed was:

1 Modify comment in ColumnDefinitionNode.
2 Remove assert which became surplus in ColumnDescriptor
3 Add comment to complicated conditional expression in ResultSetNode
4 Remove needless modification in ColumnDefintionNode. I found it when 
trying to comment it.
5 Modify how DefaultInfoImpl have attribute of DefaultValueAutoinc.
6 Add final to DefaultInfoImpl.BITS_MASK_IS_DEFAULTVALUE_AUTOINC

Please review it again.

Best regards.

/*

         Tomohito Nakayama
         tomonaka@basil.ocn.ne.jp
         tomohito@rose.zero.ad.jp

         Naka
         http://www5.ocn.ne.jp/~tomohito/TopPage.html

*/

Re: Patch for DERBY-167 again*3

Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.

Thank you !

I have filed "Modify dblook to support \"GENERATED BY DEFAULT AS IDENTITY\"" 
as DERBY-308.
http://issues.apache.org/jira/browse/DERBY-308

And I have assigned myself to DERBY-308 too.
I starts it.

Best regards.

/*

         Tomohito Nakayama
         tomonaka@basil.ocn.ne.jp
         tomohito@rose.zero.ad.jp

         Naka
         http://www5.ocn.ne.jp/~tomohito/TopPage.html

*/
----- Original Message ----- 
From: "Army" <qo...@sbcglobal.net>
To: "Derby Development" <de...@db.apache.org>
Sent: Tuesday, May 24, 2005 1:34 AM
Subject: Re: Patch for DERBY-167 again*3


> Satheesh wrote:
>
>>   This looks good to me(+1).  If there are no further comments, I will 
>> commit it.
>>
>>   Since this is new feature, there may be a need for another +1 vote.
>
> Looks good to me, too.  +1.
>
> Tomohito, could you file a JIRA entry for the "dblook" side of this patch, 
> to make sure we don't lose track of it?
>
> Thanks,
> Army
>
>
>
>
> -- 
> No virus found in this incoming message.
> Checked by AVG Anti-Virus.
> Version: 7.0.322 / Virus Database: 266.11.15 - Release Date: 2005/05/22
>
> 



-- 
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.322 / Virus Database: 266.11.15 - Release Date: 2005/05/22

Re: Patch for DERBY-167 again*3

Posted by Army <qo...@sbcglobal.net>.
Satheesh wrote:

>   This looks good to me(+1).  If there are no further comments, I will 
> commit it.
> 
>   Since this is new feature, there may be a need for another +1 vote.

Looks good to me, too.  +1.

Tomohito, could you file a JIRA entry for the "dblook" side of this patch, to 
make sure we don't lose track of it?

Thanks,
Army

Re: Patch for DERBY-167 again*3

Posted by TomohitoNakayama <to...@basil.ocn.ne.jp>.
Hello.

Thank you for your observing !
I have upladed the patch to JIRA.
http://issues.apache.org/jira/browse/DERBY-167

Best regards.

/*

         Tomohito Nakayama
         tomonaka@basil.ocn.ne.jp
         tomohito@rose.zero.ad.jp

         Naka
         http://www5.ocn.ne.jp/~tomohito/TopPage.html

*/
  ----- Original Message ----- 
  From: Satheesh Bandaram
  To: Derby Development
  Sent: Saturday, May 21, 2005 2:09 AM
  Subject: Re: Patch for DERBY-167 again*3


  This looks good to me(+1).  If there are no further comments, I will 
commit it.

  Since this is new feature, there may be a need for another +1 vote.

  Satheesh

  TomohitoNakayama wrote:

    Hello.

    I have made new patch.

    What was changed was:

    1 Modify comment in ColumnDefinitionNode.
    2 Remove assert which became surplus in ColumnDescriptor
    3 Add comment to complicated conditional expression in ResultSetNode
    4 Remove needless modification in ColumnDefintionNode. I found it when 
trying to comment it.
    5 Modify how DefaultInfoImpl have attribute of DefaultValueAutoinc.
    6 Add final to DefaultInfoImpl.BITS_MASK_IS_DEFAULTVALUE_AUTOINC

    Please review it again.

    Best regards.

    /*

            Tomohito Nakayama
            tomonaka@basil.ocn.ne.jp
            tomohito@rose.zero.ad.jp

            Naka
            http://www5.ocn.ne.jp/~tomohito/TopPage.html

    */
----------------------------------------------------------------------------
No virus found in this outgoing message.
Checked by AVG Anti-Virus.
Version: 7.0.322 / Virus Database: 266.11.12 - Release Date: 2005/05/17


------------------------------------------------------------------------------


  No virus found in this incoming message.
  Checked by AVG Anti-Virus.
  Version: 7.0.322 / Virus Database: 266.11.13 - Release Date: 2005/05/19