You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2024/10/15 14:00:16 UTC

[PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Mryange opened a new pull request, #41917:
URL: https://github.com/apache/doris/pull/41917

   ## Proposed changes
   The shorten-64-to-32 check cannot detect conversions such as 64-bit to 16-bit.
   
   ```C++
   #pragma clang diagnostic push
   #pragma clang diagnostic error "-Wconversion"
   #pragma clang diagnostic ignored "-Wsign-conversion"
   #pragma clang diagnostic ignored "-Wfloat-conversion"
       {
           int64_t x = 1000000;
           int y = x;//Implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int'
       }
       {
           int64_t x = 1000000;
           int16_t y = x;//Implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int16_t' (aka 'short')
       }
       {
           int64_t x;
           uint64_t y = x;
       }
   #pragma clang diagnostic pop
   
   #pragma clang diagnostic push
   #pragma clang diagnostic error "-Wshorten-64-to-32"
       {
           int64_t x = 1000000;
           int y = x;//Implicit conversion loses integer precision: 'int64_t' (aka 'long long') to 'int'
       }
       {
           int64_t x = 1000000;
           int16_t y = x;
       }
       {
           int64_t x;
           uint64_t y = x;
       }
   #pragma clang diagnostic pop
   ```
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2414164659

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 191403 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 6f3ba81e5d9750893267957ae46251dfe38e26a0, data reload: false
   
   query1	922	392	372	372
   query2	5192	2091	2052	2052
   query3	5006	214	223	214
   query4	33578	23512	23612	23512
   query5	3455	497	448	448
   query6	228	174	161	161
   query7	4098	301	287	287
   query8	274	221	227	221
   query9	9503	2756	2770	2756
   query10	459	271	279	271
   query11	18104	15161	15301	15161
   query12	165	106	102	102
   query13	1475	428	414	414
   query14	9340	7501	7450	7450
   query15	251	173	175	173
   query16	7727	462	481	462
   query17	1413	569	563	563
   query18	1982	296	305	296
   query19	294	154	149	149
   query20	120	108	108	108
   query21	214	110	104	104
   query22	4356	4380	4209	4209
   query23	34922	34261	34027	34027
   query24	9913	2792	2800	2792
   query25	657	418	402	402
   query26	1514	161	164	161
   query27	2472	280	282	280
   query28	6541	2460	2426	2426
   query29	927	427	429	427
   query30	339	153	154	153
   query31	1038	797	828	797
   query32	104	56	58	56
   query33	725	291	307	291
   query34	922	497	525	497
   query35	907	743	755	743
   query36	1102	946	928	928
   query37	265	91	91	91
   query38	4015	3814	3919	3814
   query39	1506	1450	1424	1424
   query40	284	102	111	102
   query41	49	47	50	47
   query42	126	106	101	101
   query43	534	486	516	486
   query44	1233	812	807	807
   query45	201	166	169	166
   query46	1121	691	707	691
   query47	1942	1850	1847	1847
   query48	421	324	324	324
   query49	1214	431	421	421
   query50	841	378	398	378
   query51	7156	6978	6937	6937
   query52	103	96	88	88
   query53	255	180	185	180
   query54	887	426	436	426
   query55	78	80	79	79
   query56	288	283	288	283
   query57	1321	1170	1128	1128
   query58	251	239	245	239
   query59	3373	2944	3243	2944
   query60	304	269	269	269
   query61	102	99	102	99
   query62	864	665	678	665
   query63	217	182	182	182
   query64	4790	663	594	594
   query65	3250	3258	3191	3191
   query66	1381	337	307	307
   query67	15944	15495	15571	15495
   query68	4102	574	556	556
   query69	594	297	285	285
   query70	1136	1081	1090	1081
   query71	339	273	293	273
   query72	7046	3926	3955	3926
   query73	787	360	354	354
   query74	10156	8986	9042	8986
   query75	3459	2700	2666	2666
   query76	2840	954	923	923
   query77	551	303	299	299
   query78	10558	9602	9684	9602
   query79	1432	583	589	583
   query80	1899	449	445	445
   query81	595	240	245	240
   query82	785	139	139	139
   query83	292	134	139	134
   query84	272	70	72	70
   query85	1456	291	281	281
   query86	422	305	308	305
   query87	4482	4240	4307	4240
   query88	2823	2217	2182	2182
   query89	393	296	278	278
   query90	2092	189	189	189
   query91	133	107	100	100
   query92	64	52	50	50
   query93	1081	542	526	526
   query94	926	299	287	287
   query95	336	241	249	241
   query96	612	284	282	282
   query97	3269	3142	3113	3113
   query98	217	198	198	198
   query99	1531	1299	1315	1299
   Total cold run time: 291235 ms
   Total hot run time: 191403 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #41917: [env](compile) Replace the shorten-64-to-32 check with a conversion check.
URL: https://github.com/apache/doris/pull/41917


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2414006501

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2414157890

   TeamCity be ut coverage result:
    Function Coverage: 37.46% (9707/25916) 
    Line Coverage: 28.74% (80604/280504)
    Region Coverage: 28.17% (41689/147970)
    Branch Coverage: 24.76% (21204/85638)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/6f3ba81e5d9750893267957ae46251dfe38e26a0_6f3ba81e5d9750893267957ae46251dfe38e26a0/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2415530313

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41056 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 6f3ba81e5d9750893267957ae46251dfe38e26a0, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17574	7371	7257	7257
   q2	2016	279	272	272
   q3	12354	1054	1148	1054
   q4	10580	853	839	839
   q5	7750	3138	3082	3082
   q6	241	151	154	151
   q7	1005	607	602	602
   q8	9351	1904	1982	1904
   q9	7067	6408	6391	6391
   q10	7056	2429	2440	2429
   q11	445	247	237	237
   q12	413	216	218	216
   q13	17793	3010	2990	2990
   q14	243	226	212	212
   q15	576	516	527	516
   q16	634	582	584	582
   q17	970	558	479	479
   q18	7322	6793	6743	6743
   q19	1350	1000	853	853
   q20	474	186	188	186
   q21	3951	3047	3137	3047
   q22	1126	1021	1014	1014
   Total cold run time: 110291 ms
   Total hot run time: 41056 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7216	7181	7213	7181
   q2	331	245	235	235
   q3	3063	2979	2958	2958
   q4	2100	1834	1775	1775
   q5	5776	5759	5813	5759
   q6	227	147	146	146
   q7	2253	1873	1791	1791
   q8	3355	3498	3463	3463
   q9	9005	8931	8905	8905
   q10	3601	3570	3569	3569
   q11	588	484	494	484
   q12	844	617	601	601
   q13	9859	3216	3211	3211
   q14	313	274	278	274
   q15	593	519	521	519
   q16	681	636	641	636
   q17	1842	1609	1589	1589
   q18	8291	7704	7653	7653
   q19	1719	1391	1416	1391
   q20	2125	1910	1878	1878
   q21	5664	5369	5466	5369
   q22	1125	1103	1067	1067
   Total cold run time: 70571 ms
   Total hot run time: 60454 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2415554170

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.78 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 6f3ba81e5d9750893267957ae46251dfe38e26a0, data reload: false
   
   query1	0.03	0.03	0.02
   query2	0.06	0.04	0.03
   query3	0.22	0.06	0.06
   query4	1.64	0.10	0.10
   query5	0.49	0.50	0.54
   query6	1.13	0.73	0.72
   query7	0.01	0.02	0.02
   query8	0.03	0.03	0.03
   query9	0.56	0.49	0.52
   query10	0.56	0.55	0.54
   query11	0.14	0.11	0.11
   query12	0.14	0.11	0.11
   query13	0.63	0.61	0.60
   query14	2.72	2.72	2.74
   query15	0.89	0.83	0.85
   query16	0.41	0.38	0.38
   query17	1.07	1.00	1.05
   query18	0.20	0.19	0.19
   query19	1.86	1.86	1.93
   query20	0.01	0.01	0.02
   query21	15.35	0.56	0.59
   query22	2.77	2.43	2.14
   query23	17.03	0.88	0.93
   query24	3.48	0.76	2.07
   query25	0.30	0.14	0.10
   query26	0.41	0.13	0.13
   query27	0.05	0.04	0.03
   query28	9.98	1.11	1.07
   query29	12.54	3.21	3.24
   query30	0.25	0.06	0.06
   query31	2.87	0.39	0.38
   query32	3.26	0.46	0.46
   query33	3.04	3.03	3.02
   query34	17.06	4.45	4.42
   query35	4.45	4.51	4.48
   query36	0.67	0.47	0.48
   query37	0.08	0.05	0.06
   query38	0.04	0.04	0.04
   query39	0.03	0.02	0.03
   query40	0.15	0.12	0.13
   query41	0.08	0.02	0.02
   query42	0.03	0.03	0.02
   query43	0.03	0.02	0.03
   Total cold run time: 106.75 s
   Total hot run time: 32.78 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2414114666

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2415407621

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2414181964

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 33.22 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 6f3ba81e5d9750893267957ae46251dfe38e26a0, data reload: false
   
   query1	0.03	0.03	0.03
   query2	0.06	0.03	0.03
   query3	0.24	0.06	0.06
   query4	1.64	0.10	0.10
   query5	0.51	0.51	0.50
   query6	1.13	0.72	0.72
   query7	0.02	0.02	0.01
   query8	0.04	0.03	0.03
   query9	0.57	0.51	0.54
   query10	0.55	0.55	0.56
   query11	0.14	0.11	0.11
   query12	0.14	0.11	0.11
   query13	0.61	0.62	0.59
   query14	2.71	2.72	2.71
   query15	0.90	0.82	0.85
   query16	0.38	0.37	0.39
   query17	1.02	0.99	1.01
   query18	0.20	0.20	0.21
   query19	1.98	1.87	1.98
   query20	0.02	0.01	0.01
   query21	15.36	0.61	0.60
   query22	2.92	2.73	2.29
   query23	16.87	0.95	0.87
   query24	3.08	1.38	1.06
   query25	0.21	0.10	0.14
   query26	0.51	0.13	0.13
   query27	0.04	0.05	0.03
   query28	10.50	1.09	1.07
   query29	12.57	3.20	3.23
   query30	0.26	0.06	0.05
   query31	2.88	0.38	0.36
   query32	3.30	0.45	0.46
   query33	2.95	3.04	3.01
   query34	16.89	4.47	4.46
   query35	4.55	4.47	4.45
   query36	0.66	0.48	0.50
   query37	0.08	0.06	0.06
   query38	0.04	0.03	0.04
   query39	0.03	0.02	0.02
   query40	0.15	0.13	0.12
   query41	0.07	0.03	0.02
   query42	0.04	0.02	0.02
   query43	0.04	0.03	0.02
   Total cold run time: 106.89 s
   Total hot run time: 33.22 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2415548644

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 192102 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 6f3ba81e5d9750893267957ae46251dfe38e26a0, data reload: false
   
   query1	944	385	404	385
   query2	6264	2109	2053	2053
   query3	8687	199	208	199
   query4	34337	23719	23576	23576
   query5	3356	469	478	469
   query6	281	164	166	164
   query7	4195	289	290	289
   query8	287	218	221	218
   query9	9578	2753	2747	2747
   query10	472	278	276	276
   query11	17946	15247	15274	15247
   query12	147	99	102	99
   query13	1570	427	400	400
   query14	9145	7260	7481	7260
   query15	254	168	177	168
   query16	7966	455	461	455
   query17	1666	630	581	581
   query18	2077	315	310	310
   query19	367	159	159	159
   query20	142	115	116	115
   query21	216	110	108	108
   query22	4837	4855	4892	4855
   query23	34783	34063	33910	33910
   query24	10527	2714	2780	2714
   query25	589	407	422	407
   query26	719	163	171	163
   query27	2022	279	285	279
   query28	6633	2416	2408	2408
   query29	750	422	418	418
   query30	261	157	158	157
   query31	1076	794	823	794
   query32	96	56	59	56
   query33	687	295	305	295
   query34	898	510	504	504
   query35	920	769	759	759
   query36	1113	940	965	940
   query37	149	91	91	91
   query38	4069	3893	3875	3875
   query39	1486	1401	1434	1401
   query40	217	97	99	97
   query41	48	45	46	45
   query42	128	101	99	99
   query43	530	484	490	484
   query44	1169	816	834	816
   query45	196	164	166	164
   query46	1131	699	689	689
   query47	1922	1855	1897	1855
   query48	422	329	341	329
   query49	899	428	435	428
   query50	811	381	406	381
   query51	7047	6919	6958	6919
   query52	100	91	89	89
   query53	261	184	176	176
   query54	1213	437	436	436
   query55	83	78	78	78
   query56	297	271	307	271
   query57	1309	1156	1132	1132
   query58	222	232	231	231
   query59	3272	3139	2953	2953
   query60	290	270	256	256
   query61	107	106	102	102
   query62	872	670	673	670
   query63	227	195	186	186
   query64	3858	627	597	597
   query65	3356	3217	3232	3217
   query66	875	304	306	304
   query67	16038	15623	15599	15599
   query68	4372	562	552	552
   query69	532	295	286	286
   query70	1213	1129	1125	1125
   query71	370	285	285	285
   query72	7325	3949	3923	3923
   query73	766	357	348	348
   query74	10230	9035	9053	9035
   query75	3401	2640	2665	2640
   query76	3222	943	896	896
   query77	466	298	289	289
   query78	10554	9717	9531	9531
   query79	2490	600	604	600
   query80	1442	445	458	445
   query81	583	237	234	234
   query82	703	138	134	134
   query83	257	131	136	131
   query84	249	68	69	68
   query85	1252	294	282	282
   query86	389	311	298	298
   query87	4377	4386	4313	4313
   query88	4042	2182	2152	2152
   query89	410	289	285	285
   query90	1951	180	184	180
   query91	136	96	100	96
   query92	64	45	48	45
   query93	1865	535	536	535
   query94	989	284	279	279
   query95	352	251	245	245
   query96	612	282	282	282
   query97	3320	3169	3238	3169
   query98	214	204	193	193
   query99	1610	1319	1325	1319
   Total cold run time: 298170 ms
   Total hot run time: 192102 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2414005931

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2414131662

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 41589 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 6f3ba81e5d9750893267957ae46251dfe38e26a0, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17575	8041	7339	7339
   q2	2055	163	157	157
   q3	10578	1142	1137	1137
   q4	10239	837	792	792
   q5	7756	3127	3091	3091
   q6	241	157	152	152
   q7	1023	628	622	622
   q8	9353	1922	1993	1922
   q9	6908	6450	6446	6446
   q10	7155	2459	2472	2459
   q11	453	254	245	245
   q12	550	222	224	222
   q13	17763	3010	2999	2999
   q14	244	209	215	209
   q15	576	536	527	527
   q16	672	601	603	601
   q17	991	528	645	528
   q18	7438	6735	6754	6735
   q19	1361	1020	975	975
   q20	486	190	195	190
   q21	4033	3240	3284	3240
   q22	1136	1001	1017	1001
   Total cold run time: 108586 ms
   Total hot run time: 41589 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	7264	7245	7244	7244
   q2	324	229	234	229
   q3	2951	2789	2845	2789
   q4	1938	1706	1693	1693
   q5	5466	5495	5482	5482
   q6	226	144	143	143
   q7	2154	1712	1707	1707
   q8	3236	3434	3429	3429
   q9	8605	8643	8587	8587
   q10	3495	3466	3444	3444
   q11	568	477	477	477
   q12	812	603	578	578
   q13	12840	3058	3016	3016
   q14	310	286	261	261
   q15	570	517	527	517
   q16	690	646	643	643
   q17	1834	1597	1577	1577
   q18	7768	7423	7435	7423
   q19	1683	1393	1498	1393
   q20	2060	1811	1808	1808
   q21	5329	5257	5241	5241
   q22	1153	1036	982	982
   Total cold run time: 71276 ms
   Total hot run time: 58663 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [env](compile) Replace the shorten-64-to-32 check with a conversion check. [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #41917:
URL: https://github.com/apache/doris/pull/41917#issuecomment-2415487676

   TeamCity be ut coverage result:
    Function Coverage: 37.46% (9709/25916) 
    Line Coverage: 28.73% (80594/280504)
    Region Coverage: 28.19% (41710/147970)
    Branch Coverage: 24.77% (21211/85638)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/6f3ba81e5d9750893267957ae46251dfe38e26a0_6f3ba81e5d9750893267957ae46251dfe38e26a0/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org