You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/02 20:04:32 UTC
[GitHub] [incubator-superset] willbarrett opened a new pull request #9959: feat: Add additional information to datasets list API endpoint
willbarrett opened a new pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959
### SUMMARY
Preset would like to add some more information to the new React-based Datasets list view. We're looking to add:
- A list of owners in icon form
- The number of charts built on the datasource
- The number of fields in the datasource
- The number of metrics in the datasource
- Whether the datasource is physical or virtual (is there SQL)
This PR adds the requested information to the API endpoint.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### Reviewers
@dpgaspar @nytai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r439948075
##########
File path: superset/connectors/sqla/models.py
##########
@@ -35,6 +35,7 @@
DateTime,
desc,
ForeignKey,
+ func,
Review comment:
I'm somewhat perplexed why the imports have changed on this file as they don't seem to be used. Maybe this branch should be rebased against `master`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-658956359
Closing this until the requried FAB change is incorporated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `4.80%`.
> The diff coverage is `94.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 66.54% -4.81%
==========================================
Files 585 585
Lines 30889 30931 +42
Branches 3237 3246 +9
==========================================
- Hits 22037 20582 -1455
- Misses 8743 10170 +1427
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `71.56% <94.44%> (+0.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.03% <93.75%> (+0.22%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (+0.01%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [144 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...66273b5](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feature: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
+ Coverage 71.34% 71.36% +0.01%
==========================================
Files 585 585
Lines 30889 30899 +10
Branches 3237 3237
==========================================
+ Hits 22037 22050 +13
+ Misses 8743 8740 -3
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.99% <ø> (+0.07%)` | :arrow_up: |
| #javascript | `59.40% <ø> (ø)` | |
| #python | `71.55% <100.00%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.14% <100.00%> (+0.33%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (+0.01%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `72.72% <0.00%> (+6.81%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...3733733](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r434693930
##########
File path: superset/datasets/api.py
##########
@@ -76,10 +76,22 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"changed_by_url",
"changed_by.username",
"changed_on",
+ "columns.id",
+ "column_count",
"default_endpoint",
"explore_url",
+ "kind",
+ "metrics.id",
Review comment:
In general, adding a count of related records is a common problem for webapps and there are performant solutions. I can see us wanting to display similar information in other places, so I recommend we find a performant way forward with FAB.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett closed pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett closed pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9959: feature: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 71.16% -0.19%
==========================================
Files 585 184 -401
Lines 30889 18045 -12844
Branches 3237 0 -3237
==========================================
- Hits 22037 12841 -9196
+ Misses 8743 5204 -3539
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.16% <100.00%> (-0.38%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.14% <100.00%> (+0.33%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.37% <100.00%> (-0.14%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| ... and [421 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...3733733](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `95.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
+ Coverage 71.34% 71.39% +0.05%
==========================================
Files 585 585
Lines 30889 30968 +79
Branches 3237 3261 +24
==========================================
+ Hits 22037 22110 +73
- Misses 8743 8749 +6
Partials 109 109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.06% <ø> (+0.14%)` | :arrow_up: |
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `71.59% <95.00%> (+0.06%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.10% <94.44%> (+0.29%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (+0.01%)` | :arrow_up: |
| [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `81.65% <0.00%> (-1.39%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `55.47% <0.00%> (-1.24%)` | :arrow_down: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `88.76% <0.00%> (-1.13%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=) | `81.81% <0.00%> (-1.11%)` | :arrow_down: |
| [superset-frontend/src/explore/controlUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzLmpz) | `96.90% <0.00%> (-0.04%)` | :arrow_down: |
| [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `81.35% <0.00%> (ø)` | |
| ... and [17 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...b6901a1](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r434145201
##########
File path: superset/datasets/api.py
##########
@@ -76,10 +76,22 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"changed_by_url",
"changed_by.username",
"changed_on",
+ "columns.id",
+ "column_count",
"default_endpoint",
"explore_url",
+ "kind",
+ "metrics.id",
Review comment:
Required to join the `metrics` to get a count. I'm looking into a FAB change to make this less hacky.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `5.03%`.
> The diff coverage is `95.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 66.30% -5.04%
==========================================
Files 585 585
Lines 30889 30854 -35
Branches 3237 3261 +24
==========================================
- Hits 22037 20459 -1578
- Misses 8743 10216 +1473
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `71.20% <95.00%> (-0.33%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.10% <94.44%> (+0.29%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.37% <100.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [176 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...b6901a1](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feature: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 71.15% -0.20%
==========================================
Files 585 585
Lines 30889 30899 +10
Branches 3237 3237
==========================================
- Hits 22037 21985 -52
- Misses 8743 8799 +56
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.13% <ø> (-0.79%)` | :arrow_down: |
| #javascript | `59.40% <ø> (ø)` | |
| #python | `71.55% <100.00%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.14% <100.00%> (+0.33%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (+0.01%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...3733733](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `11.94%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
===========================================
- Coverage 71.34% 59.39% -11.95%
===========================================
Files 585 401 -184
Lines 30889 12762 -18127
Branches 3237 3246 +9
===========================================
- Hits 22037 7580 -14457
+ Misses 8743 5003 -3740
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [319 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...66273b5](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r439114934
##########
File path: superset/connectors/base/models.py
##########
@@ -51,6 +52,11 @@
]
+class DatasourceKind(Enum):
Review comment:
Most enums i've seen in python have been in SHOUT_CASE, should we be consistent here?
Also, I think if you have this extend `str` as well, then instead of returning `DatasourceKind.virtual.value` below you can return `str(DatasourceKind.virtual)`. see https://github.com/apache/incubator-superset/blob/7f6dbf838e4e527e640a002ce20bf5da1abf4a98/superset/errors.py#L24
##########
File path: superset/connectors/base/models.py
##########
@@ -99,6 +105,17 @@ def slices(self) -> RelationshipProperty:
),
)
+ @property
+ def kind(self) -> str:
+ if self.sql:
Review comment:
maybe `return DatasourceKind.virtual.value if self.sql else DatasourceKind.physical.value`?
##########
File path: superset/connectors/base/models.py
##########
@@ -377,7 +402,7 @@ def get_column(self, column_name: Optional[str]) -> Optional["BaseColumn"]:
@staticmethod
def get_fk_many_from_list(
- object_list: List[Any], fkmany: List[Column], fkmany_class: Type, key_attr: str,
+ object_list: List[Any], fkmany: List[Column], fkmany_class: Type, key_attr: str
Review comment:
hmm, why'd we lose the trailing comma here? Are you on the right version of black?
##########
File path: tests/datasets/api_tests.py
##########
@@ -23,6 +23,7 @@
import yaml
from sqlalchemy.sql import func
+import tests.test_app
Review comment:
should this be included here? I don't see any code that references it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `4.93%`.
> The diff coverage is `94.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 66.40% -4.94%
==========================================
Files 585 585
Lines 30889 30817 -72
Branches 3237 3246 +9
==========================================
- Hits 22037 20464 -1573
- Misses 8743 10174 +1431
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `71.35% <94.44%> (-0.18%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.03% <93.75%> (+0.22%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (+0.01%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [161 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...66273b5](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `5.04%`.
> The diff coverage is `94.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 66.29% -5.05%
==========================================
Files 585 585
Lines 30889 30817 -72
Branches 3237 3246 +9
==========================================
- Hits 22037 20430 -1607
- Misses 8743 10208 +1465
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `71.17% <94.44%> (-0.37%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.03% <93.75%> (+0.22%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.37% <100.00%> (-0.14%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [171 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...66273b5](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `95.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 71.20% -0.14%
==========================================
Files 585 184 -401
Lines 30889 18060 -12829
Branches 3237 0 -3237
==========================================
- Hits 22037 12860 -9177
+ Misses 8743 5200 -3543
+ Partials 109 0 -109
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.20% <95.00%> (-0.33%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.10% <94.44%> (+0.29%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.37% <100.00%> (-0.14%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
| [superset/views/tags.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdGFncy5weQ==) | `35.13% <0.00%> (-4.11%)` | :arrow_down: |
| [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `84.09% <0.00%> (-3.41%)` | :arrow_down: |
| [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `59.06% <0.00%> (-3.29%)` | :arrow_down: |
| ... and [427 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...b6901a1](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r439530867
##########
File path: superset/connectors/base/models.py
##########
@@ -377,7 +402,7 @@ def get_column(self, column_name: Optional[str]) -> Optional["BaseColumn"]:
@staticmethod
def get_fk_many_from_list(
- object_list: List[Any], fkmany: List[Column], fkmany_class: Type, key_attr: str,
+ object_list: List[Any], fkmany: List[Column], fkmany_class: Type, key_attr: str
Review comment:
Let's avoid digging into styling changes that pass CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feature: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `4.93%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 66.40% -4.94%
==========================================
Files 585 585
Lines 30889 30785 -104
Branches 3237 3237
==========================================
- Hits 22037 20443 -1594
- Misses 8743 10163 +1420
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.40% <ø> (ø)` | |
| #python | `71.34% <100.00%> (-0.19%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.14% <100.00%> (+0.33%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (+0.01%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [157 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...3733733](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r435105232
##########
File path: superset/datasets/api.py
##########
@@ -76,10 +76,22 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"changed_by_url",
"changed_by.username",
"changed_on",
+ "columns.id",
+ "column_count",
"default_endpoint",
"explore_url",
+ "kind",
+ "metrics.id",
Review comment:
@willbarrett is preparing a PR on FAB to add the ability to define a custom SQLAlchemy query for the list endpoint, should be a great new feature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett closed pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett closed pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r434693240
##########
File path: superset/datasets/api.py
##########
@@ -76,10 +76,22 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"changed_by_url",
"changed_by.username",
"changed_on",
+ "columns.id",
+ "column_count",
"default_endpoint",
"explore_url",
+ "kind",
+ "metrics.id",
Review comment:
This should not result in an N+1, given some recent work that Daniel has done. I'll update the ticket with a screenshot of the design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r434334260
##########
File path: superset/connectors/base/models.py
##########
@@ -50,6 +50,9 @@
"series",
]
+DATASOURCE_TYPE_VIRTUAL = "virtual"
Review comment:
Enum! :) http://xion.io/post/code/python-enums-are-ok.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `0.14%`.
> The diff coverage is `95.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 71.19% -0.15%
==========================================
Files 585 585
Lines 30889 30968 +79
Branches 3237 3261 +24
==========================================
+ Hits 22037 22048 +11
- Misses 8743 8805 +62
- Partials 109 115 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.28% <ø> (-0.64%)` | :arrow_down: |
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `71.59% <95.00%> (+0.06%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.10% <94.44%> (+0.29%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (+0.01%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.68%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| ... and [26 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...b6901a1](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r439530716
##########
File path: tests/datasets/api_tests.py
##########
@@ -23,6 +23,7 @@
import yaml
from sqlalchemy.sql import func
+import tests.test_app
Review comment:
Without this inclusion the test file fails when run in isolation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-639147880
I'm hoping to leverage this change in FAB: https://github.com/dpgaspar/Flask-AppBuilder/pull/1386 to improve this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r434338789
##########
File path: superset/datasets/api.py
##########
@@ -76,10 +76,22 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"changed_by_url",
"changed_by.username",
"changed_on",
+ "columns.id",
+ "column_count",
"default_endpoint",
"explore_url",
+ "kind",
+ "metrics.id",
Review comment:
cc @dpgaspar does that result in round trips for each entry in the page? It seems like a bad idea. Is number of cols/metrics necessary here? Do we have a wireframe for context?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
willbarrett commented on a change in pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#discussion_r434145201
##########
File path: superset/datasets/api.py
##########
@@ -76,10 +76,22 @@ class DatasetRestApi(BaseSupersetModelRestApi):
"changed_by_url",
"changed_by.username",
"changed_on",
+ "columns.id",
+ "column_count",
"default_endpoint",
"explore_url",
+ "kind",
+ "metrics.id",
Review comment:
Required to join the `metrics` to get a count. Same story with `columns.id` and `slices.id` I'm looking into a FAB change to make this less hacky and more performant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9959: feat: Add additional information to datasets list API endpoint
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9959:
URL: https://github.com/apache/incubator-superset/pull/9959#issuecomment-637182195
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=h1) Report
> Merging [#9959](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c7618ee54b62760ac5f738996379de0dcd5e326e&el=desc) will **decrease** coverage by `4.80%`.
> The diff coverage is `94.44%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9959 +/- ##
==========================================
- Coverage 71.34% 66.54% -4.81%
==========================================
Files 585 585
Lines 30889 30931 +42
Branches 3237 3246 +9
==========================================
- Hits 22037 20582 -1455
- Misses 8743 10170 +1427
- Partials 109 179 +70
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (-0.01%)` | :arrow_down: |
| #python | `71.56% <94.44%> (+0.02%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.56% <ø> (ø)` | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.03% <93.75%> (+0.22%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.52% <100.00%> (+0.01%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [144 more](https://codecov.io/gh/apache/incubator-superset/pull/9959/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=footer). Last update [c7618ee...66273b5](https://codecov.io/gh/apache/incubator-superset/pull/9959?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org