[GitHub] [superset] codyml commented on a diff in pull request #22670: feat(datasets): Populate Usage tab in Edit Dataset view

["codyml (via GitHub)" <gi...@apache.org>]

codyml commented on code in PR #22670:
URL: https://github.com/apache/superset/pull/22670#discussion_r1098033176


##########
superset-frontend/src/views/CRUD/data/dataset/AddDataset/EditDataset/UsageTab/UsageTab.test.tsx:
##########
@@ -0,0 +1,405 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import fetchMock from 'fetch-mock';
+import userEvent from '@testing-library/user-event';
+import { render, screen, waitFor } from 'spec/helpers/testing-library';
+import { ChartListChart, getMockChart } from 'spec/fixtures/mockCharts';
+import ToastContainer from 'src/components/MessageToasts/ToastContainer';
+import DatasetUsage from '.';
+
+const DEFAULT_DATASET_ID = '1';
+const DEFAULT_ORDER_COLUMN = 'last_saved_at';
+const DEFAULT_ORDER_DIRECTION = 'desc';
+const DEFAULT_PAGE = 0;
+const DEFAULT_PAGE_SIZE = 25;
+
+const getChartResponse = (result: ChartListChart[]) => ({
+  count: result.length,
+  result,
+});
+
+const CHARTS_ENDPOINT = 'glob:*/api/v1/chart/?*';
+const mockChartsFetch = (response: any) => {
+  fetchMock.reset();
+  fetchMock.get('glob:*/api/v1/chart/_info?*', {
+    permissions: ['can_export', 'can_read', 'can_write'],
+  });
+
+  fetchMock.get(CHARTS_ENDPOINT, response);
+};
+
+const renderDatasetUsage = () =>
+  render(
+    <>
+      <DatasetUsage datasetId={DEFAULT_DATASET_ID} />
+      <ToastContainer />
+    </>,
+    { useRedux: true, useRouter: true },
+  );
+
+const expectLastChartRequest = (params?: {
+  datasetId?: string;
+  orderColumn?: string;
+  orderDirection?: 'desc' | 'asc';
+  page?: number;
+  pageSize?: number;
+}) => {
+  const { datasetId, orderColumn, orderDirection, page, pageSize } = {
+    datasetId: DEFAULT_DATASET_ID,
+    orderColumn: DEFAULT_ORDER_COLUMN,
+    orderDirection: DEFAULT_ORDER_DIRECTION,
+    page: DEFAULT_PAGE,
+    pageSize: DEFAULT_PAGE_SIZE,
+    ...(params || {}),
+  };
+
+  const calls = fetchMock.calls(CHARTS_ENDPOINT);
+  expect(calls.length).toBeGreaterThan(0);
+  const lastChartRequestUrl = calls[calls.length - 1][0];
+  expect(lastChartRequestUrl).toMatch(
+    new RegExp(`col:datasource_id,opr:eq,value:%27${datasetId}%27`),
+  );
+
+  expect(lastChartRequestUrl).toMatch(
+    new RegExp(`order_column:${orderColumn}`),
+  );
+
+  expect(lastChartRequestUrl).toMatch(
+    new RegExp(`order_direction:${orderDirection}`),
+  );
+
+  expect(lastChartRequestUrl).toMatch(new RegExp(`page:${page}`));
+  expect(lastChartRequestUrl).toMatch(new RegExp(`page_size:${pageSize}`));
+};
+
+test('shows loading state', () => {
+  mockChartsFetch(
+    new Promise(resolve =>
+      setTimeout(() => resolve(getChartResponse([])), 250),
+    ),
+  );
+
+  renderDatasetUsage();
+
+  const loadingIndicator = screen.getByRole('status', {

Review Comment:
   Good catch, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org