[GitHub] [incubator-druid] vogievetsky commented on a change in pull request #8994: update web-console data loader to support unified s3 and google input sources

[GitBox <gi...@apache.org>]

vogievetsky commented on a change in pull request #8994: update web-console data loader to support unified s3 and google input sources
URL: https://github.com/apache/incubator-druid/pull/8994#discussion_r354380738
 
 

 ##########
 File path: web-console/src/utils/ingestion-spec.tsx
 ##########
 @@ -1173,11 +1174,34 @@ export function getIoConfigFormFields(ingestionComboType: IngestionComboType): F
           type: 'string-array',
           placeholder: 's3://your-bucket/some-path1, s3://your-bucket/some-path2',
           required: true,
-          defined: ioConfig => !deepGet(ioConfig, 'inputSource.uris'),
+          defined: ioConfig =>
+            !deepGet(ioConfig, 'inputSource.uris') && !deepGet(ioConfig, 'inputSource.objects'),
           info: (
             <>
               <p>A list of paths (with bucket) where your files are stored.</p>
-              <p>Either S3 URIs or S3 prefixes must be set.</p>
+              <p>Either S3 URIs or prefixes or objects must be set.</p>
+            </>
+          ),
+        },
+        {
+          name: 'inputSource.objects',
+          label: 'S3 objects',
+          type: 'json',
+          required: true,
 
 Review comment:
   It would be cool to provide a `placeholder` to show what kind of shape of thing goes in here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org