You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/07/04 17:20:10 UTC

[GitHub] [netbeans] KacerCZ opened a new pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

KacerCZ opened a new pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231


   https://issues.apache.org/jira/browse/NETBEANS-4340
   
   Added CLI options to PHP Mess Detector configuration.
   
   Before:
   ![options-before](https://user-images.githubusercontent.com/4249184/86517689-2d3c0200-be2b-11ea-99c7-b907d7f467d7.png)
   ![customizer-before](https://user-images.githubusercontent.com/4249184/86517690-3036f280-be2b-11ea-9fae-5887fdc7168c.png)
   
   After:
   ![options-after](https://user-images.githubusercontent.com/4249184/86517694-42b12c00-be2b-11ea-86ec-5df3ee3f93e7.png)
   ![customizer-after](https://user-images.githubusercontent.com/4249184/86517696-45ac1c80-be2b-11ea-9d1c-a64c30110ae3.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#issuecomment-656126131


   @tmysik It's OK with me :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#issuecomment-654602225


   > I found issue with customizer panel (Source > Inspect > Configuration > Manage) that dialog is too small and Options text field is not visible. You have to resize the dialog manually to see it.
   > 
   > How can this be fixed?
   > Is it issue with this panel or in including [AdjustConfigurationPanel](https://github.com/apache/netbeans/blob/master/ide/code.analysis/src/org/netbeans/modules/analysis/ui/AdjustConfigurationPanel.java)?
   
   We should separate it from this issue.
   
   @jlahoda Is `AdjustConfigurationPanel` resizable automatically?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on a change in pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#discussion_r451105994



##########
File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/MessDetectorAnalyzerImpl.java
##########
@@ -223,6 +224,20 @@ private FileObject getValidRuleSetFile() {
         return FileUtil.toFileObject(new File(ruleSetFile));
     }
 
+    @CheckForNull
+    private String getValidOptions() {
+        String options = null;
+        Preferences settings = context.getSettings();
+        if (settings != null) {
+            options = settings.get(MessDetectorCustomizerPanel.OPTIONS, null);
+        }
+        if (options == null) {
+            options = AnalysisOptions.getInstance().getMessDetectorOptions();
+        }
+        assert options != null;

Review comment:
       I removed the assert.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik merged pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on a change in pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on a change in pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#discussion_r451106334



##########
File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/options/AnalysisOptions.java
##########
@@ -142,6 +143,15 @@ public void setMessDetectorRuleSetFilePath(String ruleSetFilePath) {
         getPreferences().put(MESS_DETECTOR_RULE_SET_FILE, ruleSetFilePath);
     }
 
+    @CheckForNull
+    public String getMessDetectorOptions() {
+        return getPreferences().get(MESS_DETECTOR_OPTIONS, "");

Review comment:
       I changed default value to `null`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on a change in pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
junichi11 commented on a change in pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#discussion_r450610078



##########
File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/MessDetectorAnalyzerImpl.java
##########
@@ -223,6 +224,20 @@ private FileObject getValidRuleSetFile() {
         return FileUtil.toFileObject(new File(ruleSetFile));
     }
 
+    @CheckForNull
+    private String getValidOptions() {
+        String options = null;
+        Preferences settings = context.getSettings();
+        if (settings != null) {
+            options = settings.get(MessDetectorCustomizerPanel.OPTIONS, null);
+        }
+        if (options == null) {
+            options = AnalysisOptions.getInstance().getMessDetectorOptions();
+        }
+        assert options != null;

Review comment:
       Remove?

##########
File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/options/AnalysisOptions.java
##########
@@ -142,6 +143,15 @@ public void setMessDetectorRuleSetFilePath(String ruleSetFilePath) {
         getPreferences().put(MESS_DETECTOR_RULE_SET_FILE, ruleSetFilePath);
     }
 
+    @CheckForNull
+    public String getMessDetectorOptions() {
+        return getPreferences().get(MESS_DETECTOR_OPTIONS, "");

Review comment:
       `null` or add `NOI18N`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#issuecomment-656113877


   @junichi11 @KacerCZ 
   
   I am going to merge it soon - OK?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#issuecomment-653792752


   @junichi11 @tmysik I found issue with customizer panel (Source > Inspect > Configuration > Manage) that dialog is too small and Options text field is not visible. You have to resize the dialog manually to see it.
   
   How can this be fixed?
   Is it issue with this panel or in including [AdjustConfigurationPanel](https://github.com/apache/netbeans/blob/master/ide/code.analysis/src/org/netbeans/modules/analysis/ui/AdjustConfigurationPanel.java)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on a change in pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
tmysik commented on a change in pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#discussion_r452198547



##########
File path: php/php.code.analysis/src/org/netbeans/modules/php/analysis/ui/analyzer/MessDetectorCustomizerPanel.java
##########
@@ -86,28 +87,30 @@ public MessDetectorCustomizerPanel(Analyzer.CustomizerContext<Void, MessDetector
     }
 
     private void init() {
+        setEnabledCheckBox();
+        setRuleSetsList();
+        setRuleSetFileTextField();
+        setOptionsTextField();

Review comment:
       Perhaps a bit better name for these methods would be `init...`.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#issuecomment-653795195


   Not sure if it is applicable also here but usually a minimum size of the dialog can be defined.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] KacerCZ commented on pull request #2231: [NETBEANS-4340] Added PHP Mess Detector options configuration

Posted by GitBox <gi...@apache.org>.
KacerCZ commented on pull request #2231:
URL: https://github.com/apache/netbeans/pull/2231#issuecomment-656227420


   Thank you.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists