[GitHub] [kafka] jsancio commented on a diff in pull request #13555: MINOR: Move `ControllerPurgatory` to `server-common`

["jsancio (via GitHub)" <gi...@apache.org>]

jsancio commented on code in PR #13555:
URL: https://github.com/apache/kafka/pull/13555#discussion_r1172724317


##########
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##########
@@ -26,10 +26,9 @@
 
 /**
  * The purgatory which holds events that have been started, but not yet completed.

Review Comment:
   Minor but can we avoid the use of the word purgatory? It is not accurate for what this type and package are doing.



##########
server-common/src/main/java/org/apache/kafka/purgatory/DeferredEventPurgatory.java:
##########
@@ -26,10 +26,9 @@
 
 /**
  * The purgatory which holds events that have been started, but not yet completed.
- * We wait for the high water mark of the metadata log to advance before completing
- * them.
+ * We wait for the high watermark of the log to advance before completing them.
  */
-class ControllerPurgatory {
+public class DeferredEventPurgatory {

Review Comment:
   Maybe a more accurate name could be `OffsetBasedCompletion`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org