You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/05 09:08:46 UTC
[GitHub] [superset] winglight opened a new issue, #20604: Other admin users can't see "saved queries" created by another admin users
winglight opened a new issue, #20604:
URL: https://github.com/apache/superset/issues/20604
A clear and concise description of what the bug is.
#### How to reproduce the bug
1. Go to 'SQL Lab'
2. Click on 'Saved queries'
3. No items in the list
### Expected results
Show the list of all saved queries despite of creators
### Actual results
Only queries created by the current user can be shown in the list
#### Screenshots
### Environment
(please complete the following information):
- browser type and version: chrome on win11
- superset version: `commit 16654034849505109b638fd2a784dfb377238a0e`
- python version: `3.8.12`
- node.js version: `none`
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [*] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [*] I have reproduced the issue with at least the latest released version of superset.
- [*] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
My superset runs on a docker container by docker-compose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Other admin users can't see "saved queries" created by another admin users [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #20604:
URL: https://github.com/apache/superset/issues/20604#issuecomment-1975653257
@eschutho do you know if that work transpired and this was just never closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] emilija-omnisend commented on issue #20604: Other admin users can't see "saved queries" created by another admin users
Posted by GitBox <gi...@apache.org>.
emilija-omnisend commented on issue #20604:
URL: https://github.com/apache/superset/issues/20604#issuecomment-1232847616
Hello. Any news? We're trying to track our table references in Superset and this is the only part left.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on issue #20604: Other admin users can't see "saved queries" created by another admin users
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on issue #20604:
URL: https://github.com/apache/superset/issues/20604#issuecomment-1563672892
We are planning to add UUID query lookup support in the near future to fix this problem. There should be a fix in 3.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Bill0412 commented on issue #20604: Other admin users can't see "saved queries" created by another admin users
Posted by "Bill0412 (via GitHub)" <gi...@apache.org>.
Bill0412 commented on issue #20604:
URL: https://github.com/apache/superset/issues/20604#issuecomment-1515652381
I think this should be merged, otherwise the share link functionality is meaningless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pengwk commented on issue #20604: Other admin users can't see "saved queries" created by another admin users
Posted by GitBox <gi...@apache.org>.
pengwk commented on issue #20604:
URL: https://github.com/apache/superset/issues/20604#issuecomment-1274891317
This can temporarily solve the problem @emilija-omnisend @winglight
```
diff --git a/superset/queries/saved_queries/filters.py b/superset/queries/saved_queries/filters.py
index c53ff5619..a0f6f2fb9 100644
--- a/superset/queries/saved_queries/filters.py
+++ b/superset/queries/saved_queries/filters.py
@@ -65,6 +65,4 @@ class SavedQueryFilter(BaseFilter): # pylint: disable=too-few-public-methods
:returns: flask-sqlalchemy query
"""
- return query.filter(
- SavedQuery.created_by == g.user # pylint: disable=comparison-with-callable
- )
+ return query
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org