[GitHub] [spark] HyukjinKwon commented on a change in pull request #29631: [SPARK-32772][SQL][FOLLOWUP] Remove legacy silent support mode for spark-sql CLI

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #29631:
URL: https://github.com/apache/spark/pull/29631#discussion_r485320783



##########
File path: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
##########
@@ -320,9 +319,6 @@ private[hive] class SparkSQLCLIDriver extends CliDriver with Logging {
   // because the Hive unit tests do not go through the main() code path.
   if (!isRemoteMode) {
     SparkSQLEnv.init()
-    if (sessionState.getIsSilent) {
-      SparkSQLEnv.sparkContext.setLogLevel(Level.WARN.toString)

Review comment:
       @wangyum, I was just double checking. Shouldn't we still respect this option when the log level of this class is explicitly set? It's a bit unlikely but I just wanted to check for doubly sure.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org