[jira] [Commented] (TAP5-2275) invalid caching response headers

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13895672#comment-13895672 ] 

ASF subversion and git services commented on TAP5-2275:
-------------------------------------------------------

Commit bf7149776891371db11f17cd92fb60fce52ca130 in branch refs/heads/master from [~thiagohp]
[ https://git-wip-us.apache.org/repos/asf?p=tapestry-5.git;h=bf71497 ]

TAP5-2275: invalid caching response headers. Adds method Response.addHeader(String,String).


> invalid caching response headers
> --------------------------------
>
>                 Key: TAP5-2275
>                 URL: https://issues.apache.org/jira/browse/TAP5-2275
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-kaptcha
>    Affects Versions: 5.3.7
>            Reporter: Ilya Obshadko
>
> please check this issue at Google Code:
> https://code.google.com/p/kaptcha/issues/detail?id=72
> There are two subsequent calls to setHeader() and second call is overriding the first one (that is already mentioned in code comments). Either support for addHeader () is needed in Response, or we need to inject HttpServletResponse directly.
>         response.setDateHeader("Expires", 0);
>         // Set standard HTTP/1.1 no-cache headers.
>         response.setHeader("Cache-Control", "no-store, no-cache, must-revalidate");
>         // Set IE extended HTTP/1.1 no-cache headers (use addHeader).
>         response.setHeader("Cache-Control", "post-check=0, pre-check=0");
>         // Set standard HTTP/1.0 no-cache header.
>         response.setHeader("Pragma", "no-cache");
> Expires: 0 is still enough for all browsers except Firefox, which doesn't reload the image, and the whole component becomes unusable.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)