[jira] [Commented] (KAFKA-6914) Kafka Connect - Plugins class should have a constructor that can take in parent ClassLoader

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634495#comment-16634495 ] 

ASF GitHub Bot commented on KAFKA-6914:
---------------------------------------

kkonstantine opened a new pull request #5720: KAFKA-6914: Set parent classloader of DelegatingClassLoader same as the worker's
URL: https://github.com/apache/kafka/pull/5720
 
 
   The parent classloader of the DelegatingClassLoader and therefore the classloading scheme used by Connect does not have to be fixed to the System classloader.
   
   Setting it the same as the one that was used to load the DelegatingClassLoader class itself is more flexible and, while in most cases will result in the System classloader to be used, it will also work in othr managed environments that control classloading differently (OSGi, and others).
   
   The fix is minimal and the mainstream use is tested via system tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Kafka Connect - Plugins class should have a constructor that can take in parent ClassLoader
> -------------------------------------------------------------------------------------------
>
>                 Key: KAFKA-6914
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6914
>             Project: Kafka
>          Issue Type: Improvement
>          Components: KafkaConnect
>            Reporter: Sriram KS
>            Assignee: Konstantine Karantasis
>            Priority: Minor
>
> Currently Plugins class has a single constructor that takes in map of props.
> Please make Plugin class to have a constructor that takes in a classLoader as well and use it to set DelegationClassLoader's parent classLoader.
> Reason:
> This will be useful if i am already having a managed class Loader environment like a Spring boot app which resolves my class dependencies using my maven/gradle dependency management.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)