You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gora.apache.org by djkevincr <gi...@git.apache.org> on 2016/08/14 20:04:34 UTC

[GitHub] gora pull request #75: Gora 409 tutorial

GitHub user djkevincr opened a pull request:

    https://github.com/apache/gora/pull/75

    Gora 409 tutorial

    @lewismc I have added new tutorial class ( DistributedLogManager.java ) and I have added few fixes for the issues encountered while testing the module. Please go through the sample and let me know what you think and I could add some changes accordingly. If you could give me access to Apache-Gora site, I could add some documentation there as well.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/djkevincr/gora GORA-409_Tutorial

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/75.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #75
    
----
commit a02c5dd9ff307cafdd89ff57c1fdd7f02cd06867
Author: Kevin <dj...@yahoo.com>
Date:   2016-08-14T19:41:56Z

    GORA-409 tutorial

commit ee6b6c058efc7194610f3b5b3e7b7d17564ff324
Author: Kevin <dj...@yahoo.com>
Date:   2016-08-14T19:50:42Z

    fixing formatting issues

commit ba277032722bcba8710cbdcb7c0573c9a8c9649d
Author: Kevin <dj...@yahoo.com>
Date:   2016-08-14T19:57:22Z

    fixing formatting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request #75: Gora 409 tutorial

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/gora/pull/75


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #75: Gora 409 tutorial

Posted by djkevincr <gi...@git.apache.org>.

Github user djkevincr commented on the issue:

    https://github.com/apache/gora/pull/75
  
    @lewismc I have fixed the formatting issues. Can you please have a look?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #75: Gora 409 tutorial

Posted by djkevincr <gi...@git.apache.org>.

Github user djkevincr commented on the issue:

    https://github.com/apache/gora/pull/75
  
    @lewismc I have pushed the changes related to bin/gora script. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #75: Gora 409 tutorial

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/75
  
    Thanks @djkevincr I will review.
    For the time being, the site source can be found at http://svn.apache.org/repos/asf/gora/site/
    Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #75: Gora 409 tutorial

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/75
  
    Please take a look at the Javadoc you've added to DistrobutedLogManager. It needs to be improved.
    <img width="1105" alt="screen shot 2016-08-14 at 3 46 15 pm" src="https://cloud.githubusercontent.com/assets/1165719/17652596/5908b3b6-6235-11e6-9b4d-34675b55ed2f.png">
    
    Please format it correctly with the correct enumeration for the list items, code examples, etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora issue #75: Gora 409 tutorial

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on the issue:

    https://github.com/apache/gora/pull/75
  
    Thanks @djkevincr , I haven't seen any updates to the [bin/gora](https://github.com/apache/gora/blob/master/bin/gora) script. Can you please make the relevant trivial updates such that DistributedLogManager is easily accessible to users from the command line? Thanks, once this is done we can merge to master. Good work. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---